New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root Workspace Sort Dropdown (Alphabetical) #3481
base: develop
Are you sure you want to change the base?
Conversation
…anted behaviour, but expected behaviour is promising.
Old file version that exists in a newer branch
Unit testing
Implemented alphabetic sort
Create drop down
Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:
Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run |
Move new feature description to latest unreleased develop
Reverted hard change
reverted committed changes to current develop branch
Thank you very much for this PR. Thus far, it looks good from a code perspective, but I think there are a few conceptual issues we might want to discuss before moving forward.
@kyaso What are your thoughts on this? |
I have no particular opinion on point 1, but if the quoted part is a potential issue, I would agree with moving the sort to the configuration (@nathanlesage: is "configuration" in this context equivalent to the "store.state.fileTree"?)
I would also say that the preferences might be a more suitable place for that.
I agree with this one.
Unfortunately, I'm not too familiar with that part of the codebase. But yeah, I guess it might be worth investigating. |
Yes, I meant to implement it in the config provider, or in the FSAL. One of those two places already implements some form of root sorting, I think it should be the FSAL. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Added dropdown box in the workspace directory list to sort root workspaces alphabetically (ascending/descending).
Addresses enhancement #3057 which was concerned with same-name root directories of different parent folders not being
ordered alphabetically.
Image of the dropdown
Changes
small dropdown textbox is positioned next to the Workspaces header, and scales with the sidebar and window size.
Additional information
- The development team is doing this as part of a university course, and would appreciate any feedback
** gui.sort_by_option
** gui.alphabetical_asc_option
** gui.alphabetical_desc_option
placeholder text is available until translation files are updated
Tested on: Windows 10 Home 64-bit (10.0 Build 19044), Ubuntu 20.04.4 LTS, macOS BigSur 11.6