Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(orchard): Update orchard for zebra-consensus #8529

Merged
merged 2 commits into from
May 18, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The upgrade of orchard for zebra-consensus just needs some changes in tests. This PR can be merged as is except for deny.toml issues that we might need to fix if we ever need to support 2 versions of orchard.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Upgrade orchard to 0.7.0 only in the zebra-consensus crate.

Testing

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage requested review from a team as code owners May 14, 2024 21:23
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team May 14, 2024 21:23
@oxarbitrage oxarbitrage changed the title depc(orchard): Update orchard for zebra-consensus deps(orchard): Update orchard for zebra-consensus May 14, 2024
mergify bot added a commit that referenced this pull request May 14, 2024
mergify bot added a commit that referenced this pull request May 18, 2024
@oxarbitrage
Copy link
Contributor Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 18, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit e0da45b into main May 18, 2024
137 checks passed
@mergify mergify bot deleted the orchard-for-zebra-consensus branch May 18, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants