Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adds full sync jobs for 1800k, 1810k, and 1820k blocks #5372

Closed
wants to merge 1 commit into from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 10, 2022

Motivation

This is the standard fix for when the full sync job runs too long.

Specifications

Solution

Add full sync jobs for 1800k, 1810k, and 1820k blocks

Review

Anyone can review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Oct 10, 2022
@arya2 arya2 self-assigned this Oct 10, 2022
@github-actions github-actions bot added C-bug Category: This is a bug C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 10, 2022
@arya2 arya2 changed the title fix(ci): adds jobs for 1800k, 1810k, and 1820k blocks fix(ci): adds full sync jobs for 1800k, 1810k, and 1820k blocks Oct 10, 2022
@arya2 arya2 marked this pull request as ready for review October 10, 2022 23:15
@arya2 arya2 requested a review from a team as a code owner October 10, 2022 23:15
@arya2 arya2 requested review from dconnolly and teor2345 and removed request for a team and dconnolly October 10, 2022 23:15
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arya2 thanks for doing this fix!

But I think this PR will conflict with PR #5367, which reverts the compute-ssh changes to these workflows.

Also, we usually update the checkpoints before adding new jobs, because it changes the sync timings:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/continuous-integration.md#fixing-ci-sync-timeouts

There's an open checkpoint update in PR #5360, do we need to skip it and go straight to this change?

.github/workflows/deploy-gcp-tests.yml Show resolved Hide resolved
@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label Oct 10, 2022
@arya2
Copy link
Contributor Author

arya2 commented Oct 10, 2022

There's an open checkpoint update in PR #5360, do we need to skip it and go straight to this change?

It may have been excessively pre-emptive.

I'll close this for now and remove two of the three steps so that it follows the 4-5h guideline if it's needed after #5367 has merged.

@arya2 arya2 closed this Oct 10, 2022
@teor2345
Copy link
Contributor

There's an open checkpoint update in PR #5360, do we need to skip it and go straight to this change?

It may have been excessively pre-emptive.

No worries, thanks for doing this!

It's just we're at a tricky stage with CI fixes right now.

@arya2
Copy link
Contributor Author

arya2 commented Oct 12, 2022

Opened a new PR #5391 off this branch because the rebase was force pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants