Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Show logs after each Google Cloud test job #5358

Closed
wants to merge 6 commits into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 6, 2022

Motivation

PR #5330 stopped showing any test logs in Google Cloud test runs that use the ssh-compute action.

But we need those logs to diagnose test failures.

Solution

Add a step that shows the logs after each time we run ssh-compute

Review

This PR is urgent because we need to be able to diagnose google cloud failures.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 A-diagnostics Area: Diagnosing issues or monitoring performance labels Oct 6, 2022
@teor2345 teor2345 self-assigned this Oct 6, 2022
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 6, 2022
@teor2345 teor2345 changed the title fix(ci): Show logs at the end of Google Cloud tests fix(ci): Show logs after each Google Cloud test job Oct 6, 2022
@teor2345 teor2345 marked this pull request as ready for review October 6, 2022 22:18
@teor2345 teor2345 requested a review from a team as a code owner October 6, 2022 22:18
@teor2345 teor2345 requested review from dconnolly and gustavovalverde and removed request for a team October 6, 2022 22:19
dconnolly
dconnolly previously approved these changes Oct 6, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

I think we're running into the 1 MB step output limit here:
https://github.com/ZcashFoundation/zebra/actions/runs/3200985566/jobs/5228636615

Longer-term, we could use log artifacts:
https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts
Or modify the ssh-compute GitHub action so it shows the SSH output.

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

Failed with:

Error: Unable to locate the previous sha: de3640d
Error: You seem to be missing 'fetch-depth: 0' or 'fetch-depth: 2'. See https://github.com/tj-actions/changed-files#usage

https://github.com/ZcashFoundation/zebra/actions/runs/3203562017/jobs/5233804843#step:3:97

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

Failed with:

ERROR: (gcloud.compute.start-iap-tunnel) Error while connecting [4010: 'destination read failed'].
kex_exchange_identification: Connection closed by remote host

This is #5362

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tee hee | tail

@gustavovalverde
Copy link
Member

Superseded by #5367

@teor2345 teor2345 closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants