[Issue #129] Fix duplicated META-INF/*.kotlin_module issue

[slmlt]

No description provided.

[ZacSweers]

Let's DRY this up a bit by moving the KotlinCompile configuration to the root build file and have it run on subprojects, then make the module name reuse the artifact ID gradle property that each project already has (see their gradle.properties)

[slmlt]

Done :) Used POM_ARTIFACT_ID from gradle.properties

[ZacSweers]

Thanks! I plan to cut a release after KSP beta05 is out, hopefully this week

[ZacSweers]

@slmlt when I try this locally, I see the following warnings. Are you familiar with them and what possible recourse there is?

> Task :moshi-sealed:codegen:kaptGenerateStubsKotlin
w: Argument -module-name is passed multiple times. Only the last value will be used: moshi-sealed-codegen

> Task :moshi-sealed:codegen-ksp:kspKotlin
w: Argument -module-name is passed multiple times. Only the last value will be used: moshi-sealed-ksp

> Task :moshi-sealed:codegen-ksp:compileKotlin
w: Argument -module-name is passed multiple times. Only the last value will be used: moshi-sealed-ksp

[slmlt]

@ZacSweers I may be wrong about this, but I assume, that KotlinCompile task has its own default arguments (KotlinCompile.createCompilerArgs()), including the "-module-name" (seems to come from K2JVMCompilerArguments.moduleName) which we cannot modify. By specifying additional compiler options (through freeCompilerArgs property) we rely on the fact, that for compiler options with matching names only the last value will be used (the very same statement we got warnings about), so the warnings are somewhat expected. Unfortunately this is the only workaround I was able to find.

[ZacSweers]

Do you know if there's a feature request on youtrack? Otherwise we should file one, this prevents use of -Werror

[slmlt]

Well, in a matter of fact there is an issue about this https://youtrack.jetbrains.com/issue/KT-42058 and it is already fixed. Now we actually can do this:
kotlinOptions.moduleName = project.property("POM_ARTIFACT_ID") as String
instead of using freeCompilerArgs. Sorry, I obviously did not put enough effort to research the problem. Here is another PR that should get rid of those warnings #134