Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moshi-sealed-runtime: More than one file was found with OS independent path 'META-INF/runtime.kotlin_module' #129

Closed
slmlt opened this issue Jul 3, 2021 · 5 comments
Closed

Moshi-sealed-runtime: More than one file was found with OS independent path 'META-INF/runtime.kotlin_module' #129

slmlt opened this issue Jul 3, 2021 · 5 comments

Comments

@slmlt
Copy link
Contributor

slmlt commented Jul 3, 2021 •
edited

After adding dev.zacsweers.moshix:moshi-sealed-runtime:0.11.2 dependency, project fails to build with the following error:
More than one file was found with OS independent path 'META-INF/runtime.kotlin_module'.
It seems like a module name mangling problem, as stated here https://ncorti.com/blog/name-mangling-in-kotlin
Possible solution is to pass the -module-name compiler flag in the library (in fact, it might prove useful to add this statement to all moshiX libraries)
@ZacSweers
Copy link
Owner

Want to send a PR?

slmlt pushed a commit to slmlt/MoshiX that referenced this issue Jul 5, 2021
[Issue ZacSweers#129] Fix duplicated META-INF/*.kotlin_module issue
7620a88
@slmlt
Copy link
Contributor Author

slmlt commented Jul 5, 2021

Sure. That should fix it: #130

slmlt pushed a commit to slmlt/MoshiX that referenced this issue Jul 5, 2021
[Issue ZacSweers#129] Fix duplicated META-INF/*.kotlin_module issue
7283612
ZacSweers pushed a commit that referenced this issue Jul 5, 2021
@slmlt
[Issue #129] Fix duplicated META-INF/*.kotlin_module issue (#130)
02d4603
@slmlt
Copy link
Contributor Author

slmlt commented Jul 5, 2021

Thanks! I plan to cut a release after KSP beta05 is out, hopefully this week

Thank you for the quick response! Would be great to see an update as soon as possible though, as this issue kinda blocks a feature in a project I am currently working on :)

@ZacSweers
Copy link
Owner

You're welcome to use a snapshot or build from source until then

ZacSweers pushed a commit that referenced this issue Jul 16, 2021
@slmlt @ZacSweers
[Issue #129] Fix duplicated META-INF/*.kotlin_module issue (#130)
5256c02
slmlt pushed a commit to slmlt/MoshiX that referenced this issue Jul 17, 2021
[Issue ZacSweers#129] Use kotlinOptions instead of freeCompilerArgs t…
e01c3d2 
…o avoid warnings
slmlt pushed a commit to slmlt/MoshiX that referenced this issue Jul 17, 2021
[Issue ZacSweers#129] Use kotlinOptions instead of freeCompilerArgs t…
7f3406e 
…o avoid warnings
ZacSweers added a commit that referenced this issue Jul 17, 2021
@slmlt @ZacSweers
[Issue #129] Use kotlinOptions instead of freeCompilerArgs to avoid w…
bf2beb3 
…arnings (#134)

* [Issue #129] Use kotlinOptions instead of freeCompilerArgs to avoid warnings

* Update access

Co-authored-by: Alexander Ivanov (KODE) <iv@appkode.ru>
Co-authored-by: Zac Sweers <pandanomic@gmail.com>
@ZacSweers
Copy link
Owner

Resolved in 0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZacSweers @slmlt