Execute Rubocop with GitHub Actions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeIwaki
force-pushed
the
github_actions_rubocop
branch
from
c51aa44
to
f32b67c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| unless target | ||
| raise TargetNotExistError.new | ||
| end | ||
| target = @targets[target_info.target_id] or raise TargetNotExistError.new |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/AndOr: Use || instead of or.
| raise "INTERNAL ERROR: missing context with id = #{context_id}" | ||
| end | ||
| context | ||
| @context_id_to_context[context_id] or raise "INTERNAL ERROR: missing context with id = #{context_id}" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/AndOr: Use || instead of or.
This reverts commit 01b15c6.
YusukeIwaki
force-pushed
the
github_actions_rubocop
branch
from
a5571b9
to
70c61f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, Style/AndOr is updated after rubocop 0.83.
rubocop/rubocop#7959
Revert the proper usage of or.