feat: use CDP's auto-attach mechanism #251
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| include Puppeteer::EventCallbackable | ||
|
|
||
| def initialize | ||
| raise NotImplementedError, 'FirefoxTargetManager is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
| end | ||
|
|
||
| def init | ||
| raise NotImplementedError, 'FirefoxTargetManager#init is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
| end | ||
|
|
||
| def available_targets | ||
| raise NotImplementedError, 'FirefoxTargetManager#available_targets is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
| end | ||
|
|
||
| def dispose | ||
| raise NotImplementedError, 'FirefoxTargetManager#dispose is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
| end | ||
|
|
||
| def add_target_interceptor(client, interceptor) | ||
| raise NotImplementedError, 'FirefoxTargetManager#add_target_interceptor is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
| end | ||
|
|
||
| def remove_target_interceptor(client, interceptor) | ||
| raise NotImplementedError, 'FirefoxTargetManager#remove_target_interceptor is not implemented yet' |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/RaiseArgs: Provide an exception object as an argument to raise.
YusukeIwaki
force-pushed
the
porting/8520
branch
from
cd0fc5b
to
49f9929
Compare
|
|
||
| private def handle_target_destroyed(event) | ||
| target_id = event['targetId'] | ||
| target_info = @discovered_targets_by_target_id.delete(target_id) |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - target_info. Did you mean target_id?
YusukeIwaki
force-pushed
the
porting/8520
branch
2 times, most recently
from
32e5d64
to
0d84586
Compare
YusukeIwaki
force-pushed
the
porting/8520
branch
from
0d84586
to
0c8016c
Compare
Porting puppeteer/puppeteer#8520