page: fix page.scrollIntoViewIfNeeded method

lib/puppeteer/element_handle.rb

@@ -169,37 +169,25 @@ class ScrollIntoViewError < StandardError; end
 
   def scroll_into_view_if_needed
     js = <<~JAVASCRIPT
-      async(element, pageJavascriptEnabled) => {
+      async(element) => {
         if (!element.isConnected)
           return 'Node is detached from document';
         if (element.nodeType !== Node.ELEMENT_NODE)
           return 'Node is not of type HTMLElement';
-
-        if (element.scrollIntoViewIfNeeded) {
-          element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
-        } else {
-          // force-scroll if page's javascript is disabled.
-          if (!pageJavascriptEnabled) {
-            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-            return false;
-          }
-          const visibleRatio = await new Promise(resolve => {
-            const observer = new IntersectionObserver(entries => {
-              resolve(entries[0].intersectionRatio);
-              observer.disconnect();
-            });
-            observer.observe(element);
-          });
-          if (visibleRatio !== 1.0)
-            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-        }
         return false;
       }
     JAVASCRIPT
     error = evaluate(js, @page.javascript_enabled) # returns String or false
     if error
       raise ScrollIntoViewError.new(error)
     end
+    begin
+      @remote_object.scroll_into_view_if_needed(@client)
+    rescue => err
+      # Just ignore 'Node does not have a layout object' for backward-compatibility.
+      raise unless err.message =~ /Node does not have a layout object/
+    end
+
     # clickpoint is often calculated before scrolling is completed.
     # So, just sleep about 10 frames
     sleep 0.16

lib/puppeteer/remote_object.rb

@@ -176,4 +176,8 @@ def converted_arg
   def set_file_input_files(client, files, backend_node_id)
     client.send_message('DOM.setFileInputFiles', objectId: @object_id, files: files, backendNodeId: backend_node_id)
   end
+
+  def scroll_into_view_if_needed(client)
+    client.send_message('DOM.scrollIntoViewIfNeeded', objectId: @object_id)
+  end
 end

spec/integration/click_spec.rb

@@ -111,7 +111,7 @@
     page.goto("#{server_prefix}/offscreenbuttons.html")
     messages = []
     page.on('console') do |message|
-      messages << message.text
+      messages << message.text if message.log_type == 'log'
     end
     11.times do |i|
       # We might've scrolled to click a button - reset to (0, 0).