Skip to content

Commit

Permalink
Merge pull request #294 from YusukeIwaki/porting/9375
Browse files Browse the repository at this point in the history
fix oopif flakiness
  • Loading branch information
YusukeIwaki committed Jan 10, 2023
2 parents 4424dcc + 69424fd commit e18d7a1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/puppeteer/frame_manager.rb
Expand Up @@ -21,6 +21,8 @@ def initialize(client, page, ignore_https_errors, timeout_settings)
# @type {!Map<string, !Frame>}
@frames = {}

@frame_naviigated_received = Set.new

# @type {!Map<number, !ExecutionContext>}
@context_id_to_context = {}

Expand All @@ -42,6 +44,7 @@ def initialize(client, page, ignore_https_errors, timeout_settings)
handle_frame_attached(client, event['frameId'], event['parentFrameId'])
end
client.on_event('Page.frameNavigated') do |event|
@frame_naviigated_received << event['frame']['id']
handle_frame_navigated(event['frame'])
end
client.on_event('Page.navigatedWithinDocument') do |event|
Expand Down Expand Up @@ -227,7 +230,9 @@ def handle_frame_tree(session, frame_tree)
if frame_tree['frame']['parentId']
handle_frame_attached(session, frame_tree['frame']['id'], frame_tree['frame']['parentId'])
end
handle_frame_navigated(frame_tree['frame'])
unless @frame_naviigated_received.delete?(frame_tree['frame']['id'])
handle_frame_navigated(frame_tree['frame'])
end
return if !frame_tree['childFrames']

frame_tree['childFrames'].each do |child|
Expand Down

0 comments on commit e18d7a1

Please sign in to comment.