Decouple snippet data and initialization cleanup

[vraja-pro]

Context

• Snippet editor has more complex way of using the hidden fields. We want to make the yoast editor store as the source of truth and sync values to the hidden fields.

Summary

This PR can be summarized in the following changelog entry:

• Remove the old sync methods and variables.

Relevant technical choices:

• setDataFromSnippet is used as a sync function to the hidden fields for the snippet editor data. I left only the case for slug since it is not meta and the sync is done within the editor.
• We set focus keyword in the initial state regardless of the analysis feature active or not. It doesn't make a difference.
• In the feature branch I added is_cornerstone to the initial state, so I'm removing the initializing and the syncing from the post data collector.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Without premium or other Yoast add-ons:
• Edit a post.
• Go to Google preview
• Change title, description and slug, try also with replacement variables
• Save and refresh, check it is saved
• Change focus keyphrase and is cornerstone and save.
• Refresh and check it is saved.

Repeat the tests for

• The term editor
• The elementor editor
• The classic editor

Test without metabox

• Comment out line 81 in class-metabox.php:

// add_action( 'add_meta_boxes', [ $this, 'add_meta_box' ] );

• Edit a post.
• Go to Google preview
• Change title, description and slug, try also with replacement variables
• Save and refresh, check it is saved.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #21225

[igorschoester]

CR 🏗️

[coveralls]

Pull Request Test Coverage Report for Build 1d06e2bcd8b4e364a23577dd57f6d091a0c70a0b

Details

• 0 of 18 (0.0%) changed or added relevant lines in 3 files are covered.
• 3848 unchanged lines in 111 files lost coverage.
• Overall coverage decreased (-4.4%) to 48.381%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/initializers/term-scraper.js	0	4	0.0%
packages/js/src/analysis/PostDataCollector.js	0	5	0.0%
packages/js/src/initializers/post-scraper.js	0	9	0.0%

Files with Coverage Reduction	New Missed Lines	%
admin/class-option-tabs-formatter.php	1	0.0%
packages/js/src/analysis/TermDataCollector.js	1	37.5%
packages/js/src/initializers/post-scraper.js	1	0.0%
src/actions/configuration/first-time-configuration-action.php	1	91.84%
src/builders/indexable-home-page-builder.php	1	98.0%
src/builders/indexable-term-builder.php	1	99.15%
src/context/meta-tags-context.php	1	28.29%
src/generators/breadcrumbs-generator.php	1	64.23%
src/generators/schema/webpage.php	1	90.32%
src/integrations/blocks/structured-data-blocks.php	1	16.0%

Totals
Change from base Build 1ed281fdbf6aa9284055b9f436a7f3afde9fc47c:	-4.4%
Covered Lines:	24965
Relevant Lines:	53480

---

💛 - Coveralls

[thijsoo]

CR + ACC 👍