Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: run CS in separate workflow & other minor tweaks #16903

Merged
merged 4 commits into from Apr 22, 2021

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 15, 2021

Context

  • Improve stability of CI runs

Summary

This PR can be summarized in the following changelog entry:

  • Improve stability of CI runs

Relevant technical choices:

As discussed in Slack this updates the Travis script to run the CS check in its own workflow.
Includes minor other tweaks and clean up.

For the record: this was the PHPCS PR which caused the difference in reported issues: squizlabs/PHP_CodeSniffer#2925

Composer: update lock file

.. to get rid of the The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. warning.

Travis: remove cruft remaining after Premium split-off

Remove ENV variable declaration and conditions which are no longer necessary since the Premium plugin has been split off and now has its own script.

Travis: run CS checks in a separate build

... with its own simplified build steps.

Composer: update the CS threshold numbers

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check out this branch
  • Run composer install
  • Run composer check-cs-thresholds and confirm that the threshold numbers are 100% correct.
  • Check the Travis output - in particularly, the output of the separate PHP 7.4: check CS run.
    • Verify that the installed PHPCS version is 3.5.8.
    • And confirm again that the threshold numbers are 100% a match.

.. to get rid of the `Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies.` warning.
Remove ENV variable declaration and conditions which are no longer necessary since the Premium plugin has been split off and now has its own script.
... with its own simplified build steps.
@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Apr 15, 2021
@jrfnl jrfnl added this to the 16.3 milestone Apr 15, 2021
@enricobattocchi enricobattocchi self-assigned this Apr 22, 2021
@enricobattocchi
Copy link
Member

Everything's OK! merging

@enricobattocchi enricobattocchi merged commit f11ea6a into trunk Apr 22, 2021
@enricobattocchi enricobattocchi deleted the feature/JRF/CI/travis-run-phpcs-separately branch April 22, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants