Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Google preview hidden fields #21225

Closed
3 tasks
Tracked by #21141
vraja-pro opened this issue Mar 12, 2024 · 1 comment · Fixed by #21328
Closed
3 tasks
Tracked by #21141

Decouple Google preview hidden fields #21225

vraja-pro opened this issue Mar 12, 2024 · 1 comment · Fixed by #21328
Assignees

Comments

@vraja-pro
Copy link
Contributor

vraja-pro commented Mar 12, 2024

  • slug
  • yoast_wpseo_metadesc
  • yoast_wpseo_title

There would be a follow up PR to cleanup the side effects.

Add defensive code

Remove event listener to hidden fields input and refresh app with the subscribe.

Add seo title and description to block editor sync and hidden fields sync

Remove load

Add initial state

Remove unused files

Test instructions:

  • Without premium or other Yoast add-ons:
  • Edit a post.
  • Go to Google preview
  • Change title, description and slug, try also with replacement variables
  • Save and refresh, check it is saved

Repeat the tests for

  • The term editor
  • The elementor editor
  • The classic editor

Test without metabox

  • Comment out line 81 in class-metabox.php:
// add_action( 'add_meta_boxes', [ $this, 'add_meta_box' ] );
  • Edit a post.
  • Go to Google preview
  • Change title, description and slug, try also with replacement variables
  • Save and refresh, check it is saved.
@igorschoester
Copy link
Member

Works!! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants