Merge pull request #18191 from Yoast/JRF/QA/main-test-minor-fix

Main_Test: set expectations in the test itself, not in the `set_up()` fixture method
Yoast · Mar 12, 2022 · e191e75 · e191e75
2 parents 253a3bf + a050e17
commit e191e75
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/tests/unit/main-test.php b/tests/unit/main-test.php
@@ -54,12 +54,6 @@ protected function set_up() {
 
 		global $wpdb;
 		$wpdb = Mockery::mock( '\wpdb' );
-
-		// Some classes call the YoastSEO function in the constructor.
-		Monkey\Functions\expect( 'YoastSEO' )
-			->andReturn( $this->instance );
-		// Deprecated classes call _deprecated_function in the constructor.
-		Monkey\Functions\expect( '_deprecated_function' );
 	}
 
 	/**
@@ -68,6 +62,13 @@ protected function set_up() {
 	 * @covers ::get_container
 	 */
 	public function test_surfaces() {
+
+		// Some classes call the YoastSEO function in the constructor.
+		Monkey\Functions\expect( 'YoastSEO' )
+			->andReturn( $this->instance );
+		// Deprecated classes call _deprecated_function in the constructor.
+		Monkey\Functions\expect( '_deprecated_function' );
+
 		$container = $this->instance->get_container();
 
 		foreach ( $container->getServiceIds() as $service_id ) {