Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: various tweaks #83

Merged
merged 2 commits into from
Nov 4, 2022
Merged

GH Actions: various tweaks #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f1647
GH Actions: harden the workflow against PHPCS ruleset errors
jrfnl Oct 23, 2022
00bf401
GH Action: PHP 8.2 builds are no longer allowed to fail
jrfnl Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/cs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ jobs:

# Check the code-style consistency of the PHP files.
- name: Check PHP code style
continue-on-error: true
id: phpcs
run: composer check-cs -- --report-full --report-checkstyle=./phpcs-report.xml

- name: Show PHPCS results in PR
if: ${{ always() && steps.phpcs.outcome == 'failure' }}
run: cs2pr ./phpcs-report.xml
2 changes: 0 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:

name: "Lint: PHP ${{ matrix.php }}"

continue-on-error: ${{ matrix.php == '8.2' }}

steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
21 changes: 8 additions & 13 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1']
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
phpunit: ['auto']
experimental: [false]

Expand Down Expand Up @@ -55,13 +55,16 @@ jobs:
- php: '8.0'
phpunit: '9.3.0'
experimental: false
- php: '8.1'
phpunit: '9.3.0'
experimental: false

# Experimental builds.
- php: '8.2'
phpunit: 'auto'
- php: '8.1'
phpunit: '^10.0'
experimental: true

- php: '8.1'
- php: '8.2'
phpunit: '^10.0'
experimental: true

Expand All @@ -86,17 +89,9 @@ jobs:

# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-composer-dependencies
- name: Install Composer dependencies for PHP < 8.2
if: ${{ matrix.php < 8.2 }}
- name: Install Composer dependencies
uses: "ramsey/composer-install@v2"

# For PHP 8.2 and above, we need to install with ignore platform reqs as not all dependencies allow it yet.
- name: Install Composer dependencies for PHP >= 8.2
if: ${{ matrix.php >= 8.2 }}
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-reqs

- name: Run the unit tests
if: ${{ matrix.phpunit != '^10.0' }}
run: composer test
Expand Down