Use black to format code #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drolando
force-pushed
the
use_black_for_code_style
branch
from
b46ea80
to
a236ad3
Compare
bplotnick
suggested changes
Feb 27, 2020
drolando
force-pushed
the
use_black_for_code_style
branch
from
a236ad3
to
32aa1c4
Compare
| @@ -89,22 +86,18 @@ def _convert_from_thrift_endpoint(self, thrift_endpoint): | |||
| """ | |||
| ipv4 = None | |||
| ipv6 = None | |||
| port = struct.unpack('H', struct.pack('h', thrift_endpoint.port))[0] | |||
| port = struct.unpack("H", struct.pack("h", thrift_endpoint.port))[0] | |||
There was a problem hiding this comment.
this reminds me of eslint in reverse
acer618
approved these changes
Feb 27, 2020
drolando
force-pushed
the
use_black_for_code_style
branch
from
32aa1c4
to
9372f29
Compare
drolando
force-pushed
the
use_black_for_code_style
branch
from
9372f29
to
c6c4379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we're doing in other repos, let's use black to format the code to ensure a consistent style