Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix tests] Remove spec=Draft4Validator from mock_validator #365

Merged
merged 1 commit into from Feb 7, 2020

Conversation

macisamuele
Copy link
Collaborator

Tests are currently failing on master

The difference in the two builds is limited to the mock library:

  • mock==3.0.5 in the green build
  • mock==4.0.0 in the failing build

The following code is causing the test setup to fail.
The change was introduced by testing-cabal/mock#476 as part of backporting the "official" unittest.mock back into the package.

In order to fix the test we could:

  1. modify jsonschema, which does raise the exception in purpose (deprecation related task)
  2. not define the spec while defining the mock
  3. limit mock to mock<4

I'm planning for approach 2 as it does not reduce our confidence around the whole interaction (especially as we have some integration tests) and does not require a lot of effort.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.502% when pulling 8004f5b on macisamuele:maci-fix-tests into 9c20a25 on Yelp:master.

@macisamuele macisamuele merged commit 35f31eb into Yelp:master Feb 7, 2020
@macisamuele macisamuele deleted the maci-fix-tests branch February 7, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants