[Fix tests] Remove spec=Draft4Validator from mock_validator #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently failing on master
The difference in the two builds is limited to the
mock
library:mock==3.0.5
in the green buildmock==4.0.0
in the failing buildThe following code is causing the test setup to fail.
The change was introduced by testing-cabal/mock#476 as part of backporting the "official"
unittest.mock
back into the package.In order to fix the test we could:
spec
while defining the mockmock
tomock<4
I'm planning for approach 2 as it does not reduce our confidence around the whole interaction (especially as we have some integration tests) and does not require a lot of effort.