DO NOT MERGE #3

Yannic · 2018-07-19T19:53:14Z

No description provided.

This reverts commit df84748. Reason for revert: To fix unit_tests (I have to revert this before the earlier patch). Likely suspect for BrowserThemePackTest.HiDpiThemeTest failing on bots. For example, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11230 : [ RUN ] BrowserThemePackTest.HiDpiThemeTest ../../chrome/browser/themes/browser_theme_pack_unittest.cc:204: Failure Expected equality of these values: "" error Which is: "File doesn't exist." Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9b98 BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() ../../chrome/browser/themes/browser_theme_pack_unittest.cc:205: Failure Value of: valid_value.get() Actual: false Expected: true Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9e0b BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() Received signal 11 SEGV_MAPERR 000000000028 #0 0x000004d00e1c base::debug::StackTrace::StackTrace() #1 0x000004d00981 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f26bba79330 <unknown> #3 0x0000050f3e24 BrowserThemePack::WriteToDisk() #4 0x000000fd22db BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() #5 0x0000026161b2 testing::Test::Run() #6 0x000002616d30 testing::TestInfo::Run() #7 0x000002617247 testing::TestCase::Run() #8 0x000002622747 testing::internal::UnitTestImpl::RunAllTests() #9 0x0000026222bd testing::UnitTest::Run() #10 0x0000045565d1 base::TestSuite::Run() #11 0x000004557fca base::(anonymous namespace)::LaunchUnitTestsInternal() #12 0x000004557e7a base::LaunchUnitTests() #13 0x00000454e155 main #14 0x7f26b86c9f45 __libc_start_main #15 0x0000006fa82a _start r8: 0000000000000000 r9: 54656d6568546970 r10: 747365545f747365 r11: 0000000000000000 r12: 000024a8af0c0d20 r13: 00007fff447924e8 r14: 00007fff44792560 r15: 0000000000000000 di: 0000000000000000 si: 00007fff44792560 bp: 00007fff44792520 bx: 00007fff44792578 dx: 00000000000005e7 ax: 0000000000001fdd cx: 0000000000000023 sp: 00007fff44792490 ip: 00000000050f3e24 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000028 [end of stack trace] Original change's description: > Compute colors for the frame and tabs from provided images. > > If theme authors explicitly provide values here, we'll use them; but if they > don't, but do provide images, set the colors to be the dominant colors of the > images, using an existing K-means algorithm (similar to what we use for > computing representative favicon colors etc.). > > This allows us to rely on those colors later when deciding what color to make > tab text, the new tab button, and similar tabstrip/window frame items. > > This also does a bit of cleanup to the theme pack code, e.g. moving a map used > in only one function into that function to make its provenance clearer. I can > try to split this apart into more CLs if desired. > > Bug: 862664 > Change-Id: I8c3f15893ad491a6fee8aa5f76ae162cecb2c6fd > Reviewed-on: https://chromium-review.googlesource.com/1152517 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578823} TBR=pkasting@chromium.org,asvitkine@chromium.org,estade@chromium.org Change-Id: I6a5a7f2916136ccf93101f36c34a17a4e5ef5d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862664 Reviewed-on: https://chromium-review.googlesource.com/1153988 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578856}

autoyannic · 2019-03-13T10:32:52Z

This repository cannot use the CommitQueue.

autoyannic · 2019-03-13T10:44:30Z

This repository cannot use the CommitQueue. Please uninstall the app from this repository.

autoyannic · 2019-03-13T10:54:23Z

This repository cannot use the CommitQueue. Please uninstall the app from this repository.

autoyannic · 2019-03-13T11:05:30Z

This repository cannot use the CommitQueue. Please uninstall the app from this repository.

Fixed by adding a WeakPtrFactory to SpeechMonitor so all posted task callbacks don't run if we destroy SpeechMonitor previously. Failure in asan: READ of size 8 at 0x7f8dc614c068 thread T0 (browser_tests) #0 0x559e511d3be4 in time_since_epoch ./../../buildtools/third_party/libc++/trunk/include/chrono:1383:103 #1 0x559e511d3be4 in operator-<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> >, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > > ./../../buildtools/third_party/libc++/trunk/include/chrono:1564:45 #2 0x559e511d3be4 in CalculateUtteranceDelayMS ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:93:15 #3 0x559e511d3be4 in chromeos::SpeechMonitor::MaybePrintExpectations() ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:230:7 #4 0x559e5edf6c45 in Run ./../../base/callback.h:98:12 #5 0x559e5edf6c45 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33 #6 0x559e5ee2dfe8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:324:23 #7 0x559e5ee2d93a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:248:7 #8 0x559e5ef7c9d6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55 #9 0x559e5ee2f188 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:429:12 #10 0x559e5eda978d in base::RunLoop::Run() ./../../base/run_loop.cc:124:14 #11 0x559e5ecac5eb in RunUntilBrowserProcessQuits ./../../chrome/test/base/in_process_browser_test.cc:362:38 #12 0x559e5ecac5eb in InProcessBrowserTest::QuitBrowsers() ./../../chrome/test/base/in_process_browser_test.cc:584:3 #13 0x559e5ecac2f7 in InProcessBrowserTest::PostRunTestOnMainThread() ./../../chrome/test/base/in_process_browser_test.cc:559:3 #14 0x559e601dc870 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:699:3 #15 0x559e5f0c5e8f in Run ./../../base/callback.h:98:12 #16 0x559e5f0c5e8f in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1640:38 #17 0x559e5f0c3bdb in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 #18 0x559e5324fc2f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:597:32 #19 0x559e57b9c078 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1020:13 #20 0x559e58ab7d34 in Run ./../../base/callback.h:98:12 #21 0x559e58ab7d34 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #22 0x559e57b993a4 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:929:25 #23 0x559e57ba10ce in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15 #24 0x559e57b94ae5 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #25 0x559e5d885212 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 #26 0x559e5d885212 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 #27 0x559e5d8844d8 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 #28 0x559e667f3da4 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:457:29 #29 0x559e5ab9eec2 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #30 0x559e601da293 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 #31 0x559e5eca7ca9 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:303:20 #32 0x559e5220cb97 in HotseatShelfAppBrowserTest::SetUp() ./../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2274:26 #33 0x559e540b8f08 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x559e540b8f08 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 #35 0x559e540bb736 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 #36 0x559e540bcc76 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 #37 0x559e540e3716 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 #38 0x559e540e23f3 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #39 0x559e540e23f3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 #40 0x559e5efb6539 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 #41 0x559e5efb6539 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 #42 0x559e5ec63f38 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 #43 0x559e6029ce29 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 #44 0x559e5ec651cb in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:247:10 #45 0x559e5ec63d69 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 #46 0x7f8dc93aabba in __libc_start_main /build/glibc-QG9qOO/glibc-2.29/csu/../csu/libc-start.c:308:16 Address 0x7f8dc614c068 is located in stack of thread T0 (browser_tests) at offset 104 in frame #0 0x559e625d8a0f in base::circular_deque<mojo::Message>::DestructRange(unsigned long, unsigned long) ./../../base/containers/circular_deque.h:998:0 Original change https://chromium-review.googlesource.com/c/chromium/src/+/2124701 TBR=nancylingwang@chromium.org, dmazzoni@chromium.org Fixed: 1065746 Test: ran tests against asan, debug, and release Change-Id: Ie3b245933969ffe182962e017515e4cf656ef05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128027 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754701}

The network process crashes flakily in these tests on trying to read a file and being blocked: [217947:217958:0403/143350.056670:FATAL:url_loader.cc(1828)] Check failed: response_. #0 0x5604f137b829 base::debug::CollectStackTrace() #1 0x5604f12a3ae3 base::debug::StackTrace::StackTrace() #2 0x5604f12b9174 logging::LogMessage::~LogMessage() #3 0x5604f2afe5d7 network::URLLoader::CompleteBlockedResponse() #4 0x5604f2afcf29 network::URLLoader::OnReceivedRedirect() #5 0x5604f194d027 net::URLRequestJob::NotifyHeadersComplete() #6 0x5604f1950a04 net::URLRequestHttpJob::NotifyHeadersComplete() #7 0x5604f1952ec2 net::URLRequestHttpJob::SaveCookiesAndNotifyHeadersComplete() #8 0x5604f1951d28 net::URLRequestHttpJob::OnStartCompleted() #9 0x5604f186697c net::HttpCache::Transaction::DoLoop() #10 0x5604ee97ab9c base::internal::Invoker<>::Run() #11 0x5604f185fae3 net::HttpNetworkTransaction::DoCallback() #12 0x5604f1820853 net::HttpStreamParser::OnIOComplete() #13 0x5604ee97ab9c base::internal::Invoker<>::Run() #14 0x5604f18c8a69 net::TCPClientSocket::DidCompleteRead() #15 0x5604f1983a9c net::TCPSocketPosix::ReadCompleted() #16 0x5604f198526a base::internal::Invoker<>::RunOnce() #17 0x5604f1987137 net::SocketPosix::RetryRead() #18 0x5604f1987eff net::SocketPosix::ReadCompleted() #19 0x5604f1987c28 net::SocketPosix::OnFileCanReadWithoutBlocking() When that happens the StoragePartition's NetworkContext is recreated. WebTestContentBrowserClient was storing the NetworkContext* into a RepeatingCallback against the advice of the method returning it (ie StoragePartition::GetNetworkContext()), and then if the process crashed, the Callback would have a dead pointer bound. This changes the tests to grab the pointer when the callback is run instead. The WebTestClientImpl's cookie_manager_ will still become useless after the network service crashes, but these tests don't depend on that... and WebTestClientImpl is created per-renderer so it should not impact other tests. R=nasko@chromium.org Bug: 1067445 Change-Id: Ieeaca88e5baee9aa3f1bf969c1486503819dcdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135424 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756369}

This reverts commit 8f16e27. Reason for revert: It doesn't fully fix the test when SplitSettingsSync is enabled. I missed one case, but I think it's easier to revert and reland. ../../chrome/browser/chromeos/login/test/js_checker.cc:110: Failure Value of: GetBool(expression) Actual: true Expected: false document.getElementById('sync-consent-impl').$$('#syncConsentOverviewDialog').hidden Stack trace: #0 0x55a3b204a99a chromeos::test::JSChecker::ExpectFalse() #1 0x55a3b204c317 chromeos::test::JSChecker::ExpectVisiblePath() #2 0x55a3aff35571 chromeos::(anonymous namespace)::SyncConsentTest::SyncConsentRecorderTestImpl() #3 0x55a3aff35193 chromeos::(anonymous namespace)::SyncConsentTest_SyncConsentRecorder_Test::RunTestOnMainThread() #4 0x55a3b1f0f111 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x55a3b195276c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x55a3b19519f9 ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x55a3b1188f84 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #8 0x7fa48e51216a content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x7fa48eaa2895 content::StartupTaskRunner::RunAllTasksNow() #10 0x7fa48e5111b3 content::BrowserMainLoop::CreateStartupTasks() #11 0x7fa48e513ee7 content::BrowserMainRunnerImpl::Initialize() #12 0x7fa48e50f336 content::BrowserMain() #13 0x7fa48ef7d613 content::ContentMainRunnerImpl::RunServiceManager() #14 0x7fa48ef7d19c content::ContentMainRunnerImpl::Run() #15 0x7fa482f36c44 service_manager::Main() #16 0x7fa48ef7b5a4 content::ContentMain() #17 0x55a3b1f0ebc8 content::BrowserTestBase::SetUp() #18 0x55a3b18dd9b0 InProcessBrowserTest::SetUp() Original change's description: > cros: Fix SyncConsentTest when SplitSettingsSync is enabled > > SplitSettingsSync adds some text to the OOBE sync consent dialog. > Update test expectations to match, otherwise the test will fail when > we flip the flag. > > Bug: 1067212 > Test: browser_tests --enable-features=SplitSettingsSync > Change-Id: Iaed6053700c1cd2d5cbaadd29443cf564a7d60b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136881 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756667} TBR=jamescook@chromium.org,xiyuan@chromium.org Change-Id: Id5fedc0af71bb3e6d221582a61c377bbdbd1a08a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137671 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756740}

We remove the secondary window bool in renderer as we no longer need to rely on it to avoid logging in devtools inspector windows. The devtools tests disable console logging in WebTestRuntimeFlags, and if we correctly replicate it to the inspector window's renderer processes (both for the first test and for subsequent ones), then no logs will be produced in the inspector. The tests in /devtools/ have console logging disabled in TestInterfaces::ConfigureForTestWithURL(), which is propagates as a WebTestRuntimeFlag to all windows and frame tree fragments - including the inspector secondary window. The /inspector-protocol/ tests similarly use console logging to drive their tests, and have a secondary window, though provided through other means seen below: #2 0x55d55b531129 content::WebContentsImpl::Init() #3 0x55d55b527234 content::WebContentsImpl::CreateWithOpener() #4 0x55d55b526f34 content::WebContents::Create() #5 0x55d55b938b57 content::Shell::CreateNewWindow() #6 0x55d55b93ce57 content::ShellDevToolsManagerDelegate::CreateNewTarget() #7 0x55d55b0d8296 content::protocol::TargetHandler::CreateTarget() #8 0x55d55b0d840e content::protocol::TargetHandler::CreateTarget() #9 0x55d55aebcbcf content::protocol::Target::DomainDispatcherImpl::createTarget() #10 0x55d55ae7fdf8 std::__1::__function::__policy_invoker<>::__call_impl<>() #11 0x55d55a3d6913 v8_crdtp::UberDispatcher::DispatchResult::Run() #12 0x55d55b0793a0 content::DevToolsSession::HandleCommandInternal() #13 0x55d55b0792cb content::DevToolsSession::HandleCommand() #14 0x55d55b07c688 base::internal::Invoker<>::RunOnce() #15 0x55d55b7fa48e content::DevToolsManagerDelegate::HandleCommand() #16 0x55d55b0791eb content::DevToolsSession::DispatchProtocolMessageInternal() #17 0x55d55b078d96 content::DevToolsSession::DispatchProtocolMessage() #18 0x55d55b94ade5 content::DevToolsProtocolTestBindings::HandleMessageFromTest() Thus we disable console logging in /inspector-protocol/ tests also to not cause regressions due to unexpected logs appearing in the secondary window. Lastly, web platform tests log to stderr instead of the console to avoid including browser-specific console logs in test expectations. However we were only setting the "IsWebPlatformTestMode" in the main frame renderer, so web platform tests that use window.open() would include logging from that window unintentionally. We move the web platform test mode into the WebTestRuntimeFlags set, so that it is propagated to all renderer processes, allowing secondary windows to stop console logging, and also allowing them to perform other tasks correctly as a bonus, such as translating URLs to the correct location. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I4ba2deb635e57d2a1f293e849e01190135064064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153891 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760549}

…l also crashes It also flakily crashes on some CQ bots, e.g. linux-rel, mac-coverage-rel. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http%2Ftests%2Fmisc%2Fsynthetic-gesture-initiated-in-cross-origin-frame.html Sample test results containing the crashes: https://test-results.appspot.com/data/layout_results/linux-rel/366388/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html Crash stack: STDERR: [812:1:0422/163319.204896:FATAL:page_animator.cc(132)] Check failed: !suppress_frame_requests_workaround_for704763_only_ || !suppress_frame_requests. STDERR: #0 0x558691d296e9 base::debug::CollectStackTrace() STDERR: #1 0x558691c4b003 base::debug::StackTrace::StackTrace() STDERR: #2 0x558691c5ff3f logging::LogMessage::~LogMessage() STDERR: #3 0x558691c607be logging::LogMessage::~LogMessage() STDERR: #4 0x558694ef219a blink::PageAnimator::SetSuppressFrameRequestsWorkaroundFor704763Only() STDERR: #5 0x558696230efb blink::WebViewFrameWidget::SetSuppressFrameRequestsWorkaroundFor704763Only() STDERR: #6 0x558694585408 blink::WidgetBase::WillBeginMainFrame() STDERR: #7 0x5586932ed733 cc::SingleThreadProxy::DoBeginMainFrame() STDERR: #8 0x5586932ed33a cc::SingleThreadProxy::CompositeImmediately() STDERR: #9 0x558693229c78 cc::LayerTreeHost::Composite() STDERR: #10 0x5586969f2137 content::WebWidgetTestProxy::SynchronouslyComposite() STDERR: #11 0x5586969f230b base::internal::Invoker<>::RunOnce() TBR=mcnee@chromium.org Bug: 1057822 Change-Id: I6a660fe8fadee611b502663471e06ceae117cc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161321 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761724}

…croll events together." This reverts commit 74f3598. Reason for revert: Makes https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/5547 crash with an MSAN issue: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=b282dea7e5ada502e5332d17ee8b04b4d1b64891&as=lock-renderer-for-middle-click-autoscroll-stderr.txt Uninitialized value was stored to memory at #0 0x5616d2abbe26 in __msan_memcpy /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1556:3 #1 0x5616d4cd84ed in ui::LatencyInfo::LatencyInfo(ui::LatencyInfo const&) ./../../ui/latency/latency_info.cc:123:50 #2 0x5616dc28f14c in make_unique<content::InputEvent, std::__1::unique_ptr<blink::WebInputEvent, std::__1::default_delete<blink::WebInputEvent>>, const ui::LatencyInfo &> ./../../buildtools/third_party/libc++/trunk/include/memory:3043:32 #3 0x5616dc28f14c in ScaleEvent ./../../content/browser/renderer_host/input/input_router_impl.cc:73:10 #4 0x5616dc28f14c in content::InputRouterImpl::FilterAndSendWebInputEvent(blink::WebInputEvent const&, ui::LatencyInfo const&, base::OnceCallback<void (blink::mojom::InputEventResultSource, ui::LatencyInfo const&, blink::mojom::InputEventResultState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>) ./../../content/browser/renderer_host/input/input_router_impl.cc:549:7 Original change's description: > Add GestureScrollId to LatencyInfo so we can tie all GestureScroll events together. > > Its useful for traces (system traces) where there are multiple chrome > traces to be able to tell which events go together. This takes the first > Async InputLatency::GestureScroll.* event, and stores the trace_id until the scroll ends. > > This will allow us to tie together begin and end events in lab metrics (TBMv3). > > See internal bug: b/150944635 > > Change-Id: I177d559a7d98d98ceab028604501c6c5c087d747 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167764 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763748} TBR=dcheng@chromium.org,tdresser@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: Ifa33639f502a61ef707ec8e4fcaca806a228c49a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#763770}

…croll events together." This reverts commit a518463. Reason for revert: Initialize gesture_scroll_id in LatencyInfo. Original change's description: > Revert "Add GestureScrollId to LatencyInfo so we can tie all GestureScroll events together." > > This reverts commit 74f3598. > > Reason for revert: Makes https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/5547 crash with an MSAN issue: > > https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=b282dea7e5ada502e5332d17ee8b04b4d1b64891&as=lock-renderer-for-middle-click-autoscroll-stderr.txt > > Uninitialized value was stored to memory at > #0 0x5616d2abbe26 in __msan_memcpy /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1556:3 > #1 0x5616d4cd84ed in ui::LatencyInfo::LatencyInfo(ui::LatencyInfo const&) ./../../ui/latency/latency_info.cc:123:50 > #2 0x5616dc28f14c in make_unique<content::InputEvent, std::__1::unique_ptr<blink::WebInputEvent, std::__1::default_delete<blink::WebInputEvent>>, const ui::LatencyInfo &> ./../../buildtools/third_party/libc++/trunk/include/memory:3043:32 > #3 0x5616dc28f14c in ScaleEvent ./../../content/browser/renderer_host/input/input_router_impl.cc:73:10 > #4 0x5616dc28f14c in content::InputRouterImpl::FilterAndSendWebInputEvent(blink::WebInputEvent const&, ui::LatencyInfo const&, base::OnceCallback<void (blink::mojom::InputEventResultSource, ui::LatencyInfo const&, blink::mojom::InputEventResultState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>) ./../../content/browser/renderer_host/input/input_router_impl.cc:549:7 > > Original change's description: > > Add GestureScrollId to LatencyInfo so we can tie all GestureScroll events together. > > > > Its useful for traces (system traces) where there are multiple chrome > > traces to be able to tell which events go together. This takes the first > > Async InputLatency::GestureScroll.* event, and stores the trace_id until the scroll ends. > > > > This will allow us to tie together begin and end events in lab metrics (TBMv3). > > > > See internal bug: b/150944635 > > > > Change-Id: I177d559a7d98d98ceab028604501c6c5c087d747 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167764 > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#763748} > > TBR=dcheng@chromium.org,tdresser@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > Change-Id: Ifa33639f502a61ef707ec8e4fcaca806a228c49a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172740 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763770} TBR=dcheng@chromium.org,tdresser@chromium.org,cwallez@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: Ied2d3ada317b5fc68524dada9fb244711134c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173058 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#763803}

This change fixes the behaviors for ++operator and --operator of AXNode::ChildIteratorBase (below I use shorthand ChildIter for ChildIteratorBase) for the following two conditions: 1. When decrementing/incrementing the ChildIter, ChildIter::child_ is no longer a descendant of ChildIter::parent_. 2. Incrementing/decrementing past iterator's beginning/end. For behavior #1 and #2, consider the following AXTree. RootWebArea root #1 ++genericContainer IGNORED ignored1 #2 ++++StaticText text1 #3 ++genericContainer IGNORED ignored2 #4 ++++StaticText text2 #5 ++genericContainer IGNORED ignored3 #6 ++++StaticText text3 #7 ---- Behavior #1, regarding ++/-- ChildIter and ChildIter::child_ is no longer a descendant of ChildIter::parent_ ------ Previously, incrementing ChildIter(parent_=ignored1, child_=text1) would give us text2's iterator, ChildIter(parent_=ignored1, child_=text2). This is incorrect since |child_=text2| is no longer a descendant of |parent_=ignored1|. The new behavior, incrementing ChildIter(parent_=ignored1, child_=text1) now gives us the iterator's end, ChildIter(parent_=ignored1, child_=null). ---- Behavior #2, regarding ++/-- past iterator's beginning/end ---- Previously, say: auto child_iter = root->UnignoredChildrenBegin(); --child_iter; // would give us UnignoredChildrenEnd() --child_iter; // would give us |ChildIter::child_=text3| Decrementing the iter would give us circular behavior. However, incrementing the iter would stay at UnignoredChildrenEnd(). This behavior is incorrect since there should not be circular behavior for both incrementing and decrementing. The new behavior gets rid of the circular behavior, incrementing past the iterator's end, would stay at UnignoredChildrenEnd(). Decrementing from iterator's end would give us the last element. For example: auto child_iter = root->UnignoredChildrenEnd(); ++child_iter; // would still stay at UnignoredChildrenEnd() auto child_iter = root->UnignoredChildrenEnd(); --child_iter; // would give us "text3" When we decrement past the iterator's beginning, we still stay at the beginning. auto child_iter = root->UnignoredChildrenBegin(); --child_iter; // would give us UnignoredChildrenBegin, "text1" ------------------------- The motivation behind this change is in the future for UpdateComputedHyperText to rely on AXNode::ChildBaseIterator in order to fix an incorrect behavior in UpdateComputedHyperText (bug:1070783) Bug: 1070783 Change-Id: Ied82923176cf02fe367b05008ffc2096b66ac70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159045 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#764146}

This reverts commit 756da00. Reason for revert: This causes my linux-chromeos build to crash as soon as I log in. Even after I recreated my profile, I'm getting this crash. [180226:180226:0508/155330.323438:FATAL:update_service.cc(278)] Check failed: !in_progress_updates_.empty(). #0 0x7f41616befd9 base::debug::CollectStackTrace() #1 0x7f41615bfab3 base::debug::StackTrace::StackTrace() #2 0x7f41615d8ff3 logging::LogMessage::~LogMessage() #3 0x7f41615d97fe logging::LogMessage::~LogMessage() #4 0x55a4a7abc56b extensions::UpdateService::UpdateCheckComplete() #5 0x55a4a79742a0 base::internal::Invoker<>::RunOnce() #6 0x55a4a7da5ab9 base::internal::FunctorTraits<>::Invoke<>() #7 0x7f416163c7f6 base::TaskAnnotator::RunTask() #8 0x7f41616559c3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #9 0x7f41616556ca base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #10 0x7f41616f8f34 base::MessagePumpLibevent::Run() #11 0x7f4161656145 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #12 0x7f416161a2d5 base::RunLoop::Run() #13 0x55a4a87ecb9f ChromeBrowserMainParts::MainMessageLoopRun() #14 0x7f415dd6ce7b content::BrowserMainLoop::RunMainMessageLoopParts() #15 0x7f415dd6ecd2 content::BrowserMainRunnerImpl::Run() #16 0x7f415dd69eba content::BrowserMain() Original change's description: > [Extensions] Remove extension ID deduplication in UpdateService > > Before this commit UpdateService used |update_extension_ids_| set to > deduplicate update requests for the same extensions. Unfortunately, > this led to issues when update request were made with different > parameters: the second request will be ignored. If the first one was > just an update, but the second one - reinstall due to corruption, the > corrupted extension will not be reinstalled. > > Bug: 1076066 > Change-Id: I44cfbb258482a2eff749c4bda3e23e001b8a8489 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181394 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Oleg Davydov <burunduk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#766802} TBR=waffles@chromium.org,burunduk@chromium.org Change-Id: Ib9960b687391467307bfd9f02e9c4afa30c676c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190469 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#767024}

…DCHECK For example: https://test-results.appspot.com/data/layout_results/linux-rel/386591/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=external/wpt/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https.html The crash stack is like: STDERR: [19926:19941:0514/142958.785731:WARNING:sync_reader.cc(170)] ASR: No room in socket buffer.: Broken pipe (32) STDERR: [19926:19941:0514/142958.875989:WARNING:sync_reader.cc(188)] SyncReader::Read timed out, audio glitch count=10 STDERR: [19893:17:0514/142958.776280:FATAL:worker_thread.cc(380)] Check failed: IsCurrentThread(). STDERR: #0 0x5565ff799849 base::debug::CollectStackTrace() STDERR: #1 0x5565ff6d1e53 base::debug::StackTrace::StackTrace() STDERR: #2 0x5565ff6e5a4f logging::LogMessage::~LogMessage() STDERR: #3 0x5565ff6e62ce logging::LogMessage::~LogMessage() STDERR: #4 0x5566025f0708 blink::WorkerThread::GlobalScope() STDERR: #5 0x5566035fbb22 blink::BaseAudioContext::UpdateWorkletGlobalScopeOnRenderingThread() STDERR: #6 0x55660368892f blink::RealtimeAudioDestinationHandler::Render() STDERR: #7 0x556603694a89 blink::AudioDestination::RequestRender() STDERR: #8 0x556603694573 blink::AudioDestination::Render() STDERR: #9 0x556603926b18 content::RendererWebAudioDeviceImpl::Render() STDERR: #10 0x5565fcef9b27 media::SilentSinkSuspender::Render() STDERR: #11 0x5565fcea3e06 media::AudioOutputDeviceThreadCallback::Process() STDERR: #12 0x5565fce997b2 media::AudioDeviceThread::ThreadMain() STDERR: #13 0x5565ff7af138 base::(anonymous namespace)::ThreadFunc() STDERR: #14 0x7fb9ebfe36ba start_thread STDERR: #15 0x7fb9e5fea41d clone TBR=wangxianzhu@chromium.org Bug: 1058403, 1073247 Change-Id: I1e3e7a4c55fc5dec87c911de36769508a636afaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203704 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769165}

This reverts commit 9cca480. Reason for revert: <INSERT REASONING HERE> See flakey failures https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVZveEJyYWlsbGVUYWJsZVRlc3QudGVzdEdldFVuY29udHJhY3RlZAw [7369:7369:0522/203957.919406:FATAL:chrome_extensions_browser_client.cc(148)] Check failed: context. #0 0x55cfe9dfc549 base::debug::CollectStackTrace() #1 0x55cfe9d09be3 base::debug::StackTrace::StackTrace() #2 0x55cfe9d20d7f logging::LogMessage::~LogMessage() #3 0x55cfe9d2156e logging::LogMessage::~LogMessage() #4 0x55cfed7b0e42 extensions::ChromeExtensionsBrowserClient::GetOriginalContext() #5 0x55cfed58f4c3 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x55cfebd733c3 KeyedServiceFactory::GetServiceForContext() #7 0x55cfea38f279 extensions::TtsExtensionEventHandler::OnTtsEvent() #8 0x55cfe73698c8 content::TtsUtteranceImpl::OnTtsEvent() #9 0x55cfe7365120 content::TtsControllerImpl::ClearUtteranceQueue() #10 0x55cfe7365f03 content::TtsControllerImpl::StopInternal() #11 0x55cfe7367071 content::TtsControllerImpl::OnBrowserContextDestroyed() #12 0x55cfe6d1d18c content::BrowserContext::~BrowserContext() #13 0x55cfea0f813f ProfileImpl::~ProfileImpl() #14 0x55cfea0f816e ProfileImpl::~ProfileImpl() #15 0x55cfea0f1f72 ProfileDestroyer::DestroyRegularProfileNow() #16 0x55cfea0f1d00 ProfileDestroyer::DestroyProfileWhenAppropriate() #17 0x55cfea1137e8 std::__1::unique_ptr<>::~unique_ptr() #18 0x55cfea114ee3 std::__1::__tree<>::destroy() #19 0x55cfea11473b ProfileManager::~ProfileManager() #20 0x55cfea10bfae ProfileManager::~ProfileManager() #21 0x55cfe9eac15a BrowserProcessImpl::StartTearDown() #22 0x55cfe9eaab2a ChromeBrowserMainParts::PostMainMessageLoopRun() #23 0x55cfe51c9e74 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #24 0x55cfe6d41ccf content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #25 0x55cfe6d43b6d content::BrowserMainRunnerImpl::Shutdown() #26 0x55cfe6d3eb02 content::BrowserMain() #27 0x55cfe97ac717 content::ContentMainRunnerImpl::RunServiceManager() #28 0x55cfe97ac2cf content::ContentMainRunnerImpl::Run() #29 0x55cfec99806a service_manager::Main() #30 0x55cfe7f60444 content::ContentMain() #31 0x55cfea5622a4 content::BrowserTestBase::SetUp() #32 0x55cfe9cf633b InProcessBrowserTest::SetUp() #33 0x55cfe579858e testing::Test::Run() #34 0x55cfe5799948 testing::TestInfo::Run() #35 0x55cfe579a5e7 testing::TestSuite::Run() #36 0x55cfe57aa747 testing::internal::UnitTestImpl::RunAllTests() #37 0x55cfe57aa179 testing::UnitTest::Run() #38 0x55cfe9e477e2 base::TestSuite::Run() #39 0x55cfe9cdf0e7 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #40 0x55cfea5a72f4 content::LaunchTests() #41 0x55cfe9cdf494 LaunchChromeTests() #42 0x55cfe9cdf032 main #43 0x7f421a16f830 __libc_start_main #44 0x55cfe29b442a _start Fixed: Fixed: 1085878, 1085877 Fixed: 1085878, 1085877 Original change's description: > Fix UAF in TtsPlatformImpl if a BrowserContext is deleted. > > Bug: 1081350 > Change-Id: I2b1824abefbd7fc3e8ce1c0cb433896161bab4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211123 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771222} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081350 Change-Id: I88ec7e523fbe56845b8480b112535b2f8e18a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213553 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771379}

This reverts commit 0af7d7a. Reason for revert: Causing failures on multiple tests in linux-trusty-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12178 Example stack trace: Received signal 11 SEGV_MAPERR 000000000008 #0 0x56517bc8acf9 base::debug::CollectStackTrace() #1 0x56517bbf6703 base::debug::StackTrace::StackTrace() #2 0x56517bc8a895 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f12826f7330 (/lib/x86_64-linux-gnu/libpthread-2.19.so+0x1032f) #4 0x56517c963d2e x11::RandR::QueryVersion() #5 0x56517ca4e18f ui::GetXrandrVersion() #6 0x56517ca4d101 ui::XDisplayManager::XDisplayManager() #7 0x56517d4af33b views::DesktopScreenX11::DesktopScreenX11() From: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878654764661294768/+/steps/extensions_browsertests_on_Ubuntu-14.04/0/logs/Deterministic_failure:_BluetoothSocketApiTest.Listen__status_CRASH_/0 Original change's description: > [XProto] Remove all remaining non-event usages of XRandR > > BUG=1066670 > R=msisov > CC=sky > > Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773876} TBR=jamiewalch@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: Id94555856b3e06dcafc0f4c78a7a737718ddd37d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225998 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773995}

…b pages/apps." This reverts commit 926cd1f. Reason for revert: Flakiness in BackGestureBrowserTest.PreventDefault Three failures observed on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel https://chromium-swarm.appspot.com/task?id=4c8d35366f7d4710#BackGestureBrowserTest.PreventDefault,BackGestureBrowserTest.TouchActions,DemoSetupArcSupportedTest.ShowOfflineSetupOptionOnNetworkList,NetworkQualityTrackerBrowserTest.SimulateNetworkServiceCrash,SwitchAccessPredicateTest.LeafPredicate,TopControlsSlideControllerTest.DisplayRotation ../../chrome/browser/ui/ash/back_gesture_browsertest.cc:210: Failure Value of: recorder.HasReceivedEvent(ui::EventType::ET_KEY_PRESSED) Actual: true Expected: false Stack trace: #0 0x5585e4320fef BackGestureBrowserTest_PreventDefault_Test::RunTestOnMainThread() #1 0x5585e7da383d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5585e7900459 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #3 0x5585e78ff599 ChromeBrowserMainParts::PreMainMessageLoopRun() #4 0x5585e4a12dd9 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #5 0x5585e5c7fd84 content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x5585e6079033 content::StartupTaskRunner::RunAllTasksNow() #7 0x5585e5c7ed8a content::BrowserMainLoop::CreateStartupTasks() #8 0x5585e5c81611 content::BrowserMainRunnerImpl::Initialize() #9 0x5585e5c7d3ad content::BrowserMain() #10 0x5585e7384f2d content::ContentMainRunnerImpl::RunServiceManager() #11 0x5585e73849b7 content::ContentMainRunnerImpl::Run() #12 0x5585e99d13d5 service_manager::Main() #13 0x5585e67835d4 content::ContentMain() #14 0x5585e7da33ba content::BrowserTestBase::SetUp() #15 0x5585e77dca3a InProcessBrowserTest::SetUp() Original change's description: > back gesture: Disable back gesture for {touch-action:none} web pages/apps. > > Bug: 1063144 > Change-Id: I85379cc2f4aded28ac9eefb09e2086d446f42168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773852} TBR=sky@chromium.org,xdai@chromium.org,dtapuska@chromium.org,afakhry@chromium.org Change-Id: I5123a071659d23d7731a55d1420442c9b878b8bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225764 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774078}

This reverts commit 6c7cfb0. Reason for revert: Causing media-unittest failures on win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/12503 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878571776794508208/+/steps/media_unittests_on_Windows-10-15063/0/logs/Deterministic_failure:_D3D11VideoDecoderTest.DoesNotSupportEncryptionWithFlagOn11_0__status_CRASH_/0 ==12148==ERROR: AddressSanitizer: heap-use-after-free on address 0x11f0e8b56314 at pc 0x7ff697ff598f bp 0x00d00939e830 sp 0x00d00939e878 READ of size 24 at 0x11f0e8b56314 thread T0 #0 0x7ff697ff59b8 in __asan_memcpy C:\b\s\w\ir\cache\builder\src\third_party\llvm\compiler-rt\lib\asan\asan_interceptors_memintrinsics.cpp:22 #1 0x7ff69882a563 in media::GetSupportedD3D11VideoDecoderResolutions C:\b\s\w\ir\cache\builder\src\media\gpu\windows\supported_profile_helpers.cc:222 #2 0x7ff69881fa44 in media::D3D11VideoDecoder::GetSupportedVideoDecoderConfigs C:\b\s\w\ir\cache\builder\src\media\gpu\windows\d3d11_video_decoder.cc:912 #3 0x7ff695f9192c in media::D3D11VideoDecoderTest::CreateDecoder C:\b\s\w\ir\cache\builder\src\media\gpu\windows\d3d11_video_decoder_unittest.cc:189 Original change's description: > Refactor GetResolutionsForDecoders() to support AV1. > > Does the following: > - Internalizes h264 and min resolution details. > - Sets the minimum resolution to 64,64 for both decoders. > - Only loops through the video device profiles once. > - Switches away from an std::pair to a named struct. > - Adds AV1 GUID values and uses them in DXVA decoder. > - Stops D3D11VideoDecoder for enumerating unsupported profiles. > - Stops using the DXVA2_Intel_ModeH264_E for enumeration. > - Gives all resolution tests a square resolution; e.g., 4k x 4k. > - Doesn't test or indicate support for a duplicate portrait resolution. > > R=liberato, tmathmeyer > > Bug: 1073252 > Test: Updated unittests. > Change-Id: I8013e89104c96fad845fdbaecdb1d4b239f9a380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223261 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774317} TBR=dalecurtis@chromium.org,liberato@chromium.org,tmathmeyer@chromium.org Change-Id: Idb9d7d61938860c46ed72cd588d48fb5eeedadf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227710 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#774435}

Same as the previous patch, but avoids assigning from a const& and skips tests which shouldn't run on Windows 7. PS#1 is take #2, all later patch sets are the new one. ---- [ Original Description Below ] ---- Does the following: - Internalizes h264 and min resolution details. - Sets the minimum resolution to 64,64 for both decoders. - Only loops through the video device profiles once. - Switches away from an std::pair to a named struct. - Adds AV1 GUID values and uses them in DXVA decoder. - Stops D3D11VideoDecoder for enumerating unsupported profiles. - Stops using the DXVA2_Intel_ModeH264_E for enumeration. - Gives all resolution tests a square resolution; e.g., 4k x 4k. - Doesn't test or indicate support for a duplicate portrait resolution. TBR=liberato, tmathmeyer Bug: 1073252 Test: Updated unittests. Change-Id: I56468b1ab56e4bc2bd872cf40cef4235d9d2afc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228112 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774515}

This reverts commit 67dc51d. Reason for reland: Added min_sdk_version to failed targets TBR=agrieve # reland Bug: 1091919 Change-Id: I169028c59d5cd66d9257db28305d6c8e2f4b385b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242637 Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#777830}

This CL is fixing the CFI detection that causes chromium bots failure. It caused that Angle roll back: https://chromium-review.googlesource.com/c/chromium/src/+/2273440 DevTools listening on ws://127.0.0.1:34485/devtools/browser/6b3d139b-d597-448f-bc99-b1a8ccf0ef57 [6573:6573:0630/045819.756406:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process. ../../ui/gl/angle_platform_impl.cc:134:13: runtime error: control flow integrity check for type 'void (void *)' failed during indirect function call (/b/s/w/ir/out/Release/libGLESv2.so+0x70e468): note: (unknown) defined here ../../ui/gl/angle_platform_impl.cc:134:13: note: check failed in /b/s/w/ir/out/Release/content_shell, destination function located in /b/s/w/ir/out/Release/libGLESv2.so #0 0x55a9dd09723f in angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0::operator()(void (*)(void*), void*) const ./../../ui/gl/angle_platform_impl.cc:134:13 #1 0x55a9dd0971a4 in void base::internal::FunctorTraits<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void>::Invoke<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, void (*&&)(void*), void*&&) ./../../base/bind_internal.h:379:12 #2 0x55a9dd097124 in void base::internal::InvokeHelper<false, void>::MakeItSo<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, void (*&&)(void*), void*&&) ./../../base/bind_internal.h:637:12 #3 0x55a9dd0970e4 in void base::internal::Invoker<base::internal::BindState<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>, void ()>::RunImpl<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, std::__1::tuple<void (*)(void*), void*>, 0ul, 1ul>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, std::__1::tuple<void (*)(void*), void*>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/bind_internal.h:710:12 #4 0x55a9dd097094 in _ZN4base8internal7InvokerINS0_9BindStateIZN5angle12_GLOBAL__N_132ANGLEPlatformImpl_postWorkerTaskEPNS3_15PlatformMethodsEPFvPvES7_E3$_0JS9_S7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE$e9746124236f50940159c137b2ecb700.cfi ./../../base/bind_internal.h:679:12 #5 0x55a9d7baab74 in base::OnceCallback<void ()>::Run() && ./../../base/callback.h:99:12 #6 0x55a9dbc25481 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33 #7 0x55a9dbc63df6 in base::internal::TaskTracker::RunSkipOnShutdown(base::internal::Task*) ./../../base/task/thread_pool/task_tracker.cc:768:19 #8 0x55a9dbc63353 in base::internal::TaskTracker::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&) ./../../base/task/thread_pool/task_tracker.cc:632:5 #9 0x55a9dbcc2c27 in base::internal::TaskTrackerPosix::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&) ./../../base/task/thread_pool/task_tracker_posix.cc:22:16 #10 0x55a9dbc6298e in base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource) ./../../base/task/thread_pool/task_tracker.cc:505:5 #11 0x55a9dbc82f5a in base::internal::WorkerThread::RunWorker() ./../../base/task/thread_pool/worker_thread.cc:348:34 #12 0x55a9dbc82c0c in base::internal::WorkerThread::RunPooledWorker() ./../../base/task/thread_pool/worker_thread.cc:223:3 #13 0x55a9dbcc3749 in _ZN4base12_GLOBAL__N_110ThreadFuncEPv$02080084496f8c17dc927fff280e5fe6.cfi ./../../base/threading/platform_thread_posix.cc:81:13 #14 0x7f331ced16b9 in start_thread /build/glibc-LK5gWL/glibc-2.23/nptl/pthread_create.c:333:0 #15 0x7f33159d141c in clone /build/glibc-LK5gWL/glibc-2.23/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:109:0 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../ui/gl/angle_platform_impl.cc:134:13 Bug: 1091259 Change-Id: Ie6d4cf36ddc40fff2864ce27ba130b9bec069ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276245 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784164}

… compile" This reverts commit 24bb7e4. Reason for reland: Fixed EmbeddedTestServer by hardcoding its target_sdk_version. Original change's description: > Revert "Reland #2 "Android: Bump default target_sdk_version 24 -> SDK used to compile"" > > This reverts commit 0763c88. > > Reason for revert: Suspected culprit of crbug.com/1103502 TBR=boliu@chromium.org,agrieve@chromium.org,bsheedy@chromium.org Bug: 1103295, 1103502 Change-Id: I507a5c643ca501493aa52f719dcb7b31c6a3d670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290319 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#787203}

This reverts commit 3d677a1. Reason for revert: `linux-chromeos-dbg` began failing in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19625, with errors along the lines of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874588910239798816/+/steps/browser_tests/0/logs/Deterministic_failure:_CrElementsFingerprintProgressArcV3Test.Fingerprint__status_CRASH_/0: ``` [9471:9471:0716/140802.869423:FATAL:dedicated_worker_host_factory.mojom.cc(574)] Check failed: !connected. DedicatedWorkerHostFactory::CreateWorkerHostCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. #0 0x7f0d6306d98f base::debug::CollectStackTrace() #1 0x7f0d62e1600d base::debug::StackTrace::StackTrace() #2 0x7f0d62e15fc8 base::debug::StackTrace::StackTrace() #3 0x7f0d62e5751b logging::LogMessage::~LogMessage() #4 0x7f0d62e57dfc logging::LogMessage::~LogMessage() #5 0x7f0d62dddf4e logging::CheckError::~CheckError() #6 0x7f0d5b24076d blink::mojom::DedicatedWorkerHostFactory_CreateWorkerHost_ProxyToResponder::OnIsConnectedComplete() ... ``` This CL is the most suspicious in the range. Reverting to see if the bot recovers. Original change's description: > Introduce DedicatedWorkerToken. > > Subsequent CLs will migrate Shared and Service workers to use similar > tokens. This is in support of the performance.measureMemory API, endowing > workers with tokens that can be used as an identifier when communicating > information regarding V8 memory usage. > > BUG=1085129, 1096617 > > Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789141} TBR=falken@chromium.org,chrisha@chromium.org,dtapuska@chromium.org,afakhry@chromium.org,wfh@chromium.org Change-Id: I420aba017ab4a7ac28d94f296355fb434d24cb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085129 Bug: 1096617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302693 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#789386}

https://skia.googlesource.com/skia.git/+log/446b974be827..1d66d3f9d4ce 2020-07-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-07-24 johnstiles@google.com Report the effect type when TestCreate returns null. 2020-07-24 michaelludwig@google.com Undo drawRRect+clipRRect merging outside of Android framework 2020-07-24 egdaniel@google.com Remove resource from GrD3DBuffer. 2020-07-24 herb@google.com properly account for GrTextBlob arena size 2020-07-24 reed@google.com demo CubicResampler 2020-07-24 jvanverth@google.com Reland "Make GrRingBuffer more generic so it can be used over all backends" 2020-07-24 robertphillips@google.com Revert "Attach whitespaces to the neighbor unresolved blocks" 2020-07-24 brianosman@google.com SkSL: Salt inline identifiers in PipelineStage and FragmentProcessor passes 2020-07-24 egdaniel@google.com Using staging buffers for uploads of d3d static buffers. 2020-07-24 brianosman@google.com Add several more values to SkYUVColorSpace 2020-07-24 jlavrova@google.com Attach whitespaces to the neighbor unresolved blocks 2020-07-24 mtklein@google.com remove more blacklists 2020-07-24 mtklein@google.com rename tools/xsan.blacklist 2020-07-24 johnstiles@google.com Enforce trivially-copyable types on unaligned loads/stores/casts. 2020-07-24 robertphillips@google.com Update more tests to use the GrDirectContext/GrRecordingContext pair 2020-07-24 johnstiles@google.com Rename bit_cast to sk_bit_cast, and migrate to SkUtils.h. 2020-07-24 csmartdalton@google.com Don't std::move fTriangleBuffer in tessellation 2020-07-24 johnstiles@google.com Remove input-color modulation from GrGLLightingEffect. 2020-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 9061d5d154bc to 0d158ac68107 (3 revisions) 2020-07-24 herb@google.com make calls to SubRun and AtlasSubRun const 2020-07-24 bsalomon@google.com Remove GrYUVProvider. 2020-07-24 jvanverth@google.com Revert "Metal: Hold refs for input buffers from bindBuffer calls." 2020-07-24 robertphillips@google.com Revert "implement working CorrectnessActivity to generate lottie keyframe PNGs" 2020-07-24 johnstiles@google.com Simplify GrPipeline by removing unused functionality. 2020-07-24 jvanverth@google.com Revert "Make GrRingBuffer more generic so it can be used over all backends" 2020-07-24 johnstiles@google.com Remove unused RunInSeries processor. 2020-07-24 johnstiles@google.com Rename Xfermode fragment processor to Blend. 2020-07-24 kjlubick@google.com Inclusive language 2020-07-24 jvanverth@google.com Metal: Hold refs for input buffers from bindBuffer calls. 2020-07-24 jlavrova@google.com Reland #3 "ICU API: only in SkParagraph, simplified." 2020-07-24 bsalomon@google.com Remove GrTexturePriv 2020-07-24 herb@google.com reduce mutex use and switch to spinlock 2020-07-24 jvanverth@google.com Make GrRingBuffer more generic so it can be used over all backends 2020-07-24 jmbetancourt@google.com implement working CorrectnessActivity to generate lottie keyframe PNGs 2020-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f359cb667cb9 to df5ed61ddbca (3 revisions) 2020-07-24 csmartdalton@google.com Rename GrStrokeGeometry -> GrStrokePatchBuilder 2020-07-24 csmartdalton@google.com Write GPU buffers directly from GrStrokeGeometry 2020-07-23 fmalita@chromium.org ResourceProviderProxyBase should not drop loadFont (yet) 2020-07-23 robertphillips@google.com Manually Roll ANGLE from 20eb9be55299 to f6659b3df028 (17 revisions) 2020-07-23 elliotevans@google.com Fix CanvasKit SkSurface.requestAnimationFrame for web workers 2020-07-23 johnstiles@google.com Add GrFragmentProcessor::Compose for composing two processors. 2020-07-23 robertphillips@google.com Convert more tests to GrDirectContext/GrRecordingContext pair If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491,chromium:1101513,chromium:1108626,chromium:842296 Tbr: robertphillips@google.com Change-Id: If668af2a8bbfadba4e66791346ed8ae6c19843b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319118 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791489}

The change https://chromium-review.googlesource.com/c/chromium/src/+/1980612 explicitly unloads various component extensions deemed to be risky. Unfortunately, the hash for ChromeVox (which was supposed to not be risky) was *wrong*, so it was being unloaded mysteriously. Test: obtain the hash for ChromeVox (extension id mdn....), via logging and print the hex hash. Verify after correcting the hash in profile_helper.cc, on-device, doing things like clicking the "Add Person" button doesn't unloads ChromeVox. Fixed: 1094031 Issue details: On the login screen, invoke the "Add Person" button. result: ChromeVox is unloaded i.e. #2 0x57e72acd8634 content::RenderFrameHostImpl::~RenderFrameHostImpl() #3 0x57e72acd8520 content::RenderFrameHostImpl::~RenderFrameHostImpl() #4 0x57e72b0bb120 content::RenderFrameHostManager::~RenderFrameHostManager() #5 0x57e72acd2449 content::FrameTreeNode::~FrameTreeNode() #6 0x57e72bffe68d content::FrameTree::~FrameTree() #7 0x57e72c20defa content::WebContentsImpl::~WebContentsImpl() #8 0x57e72c20e928 content::WebContentsImpl::~WebContentsImpl() #9 0x57e72c3d2490 extensions::ExtensionHost::~ExtensionHost() #10 0x57e72c3d253c extensions::ExtensionHost::~ExtensionHost() #11 0x57e72c40f857 extensions::ProcessManager::CloseBackgroundHost() #12 0x57e72c40fabe extensions::ProcessManager::OnExtensionUnloaded() #13 0x57e72c3ea211 extensions::ExtensionRegistry::TriggerOnUnloaded() #14 0x57e72c3e8f3a extensions::ExtensionRegistrar::DeactivateExtension() #15 0x57e72c3e8be7 extensions::ExtensionRegistrar::RemoveExtension() #16 0x57e72f781d0b extensions::ExtensionService::RemoveComponentExtension() #17 0x57e72f761c47 extensions::ComponentLoader::Remove() #18 0x57e72cb46908 chromeos::ProfileHelperImpl::ClearSigninProfile() #19 0x57e7304c57c1 chromeos::GaiaScreenHandler::StartClearingCookies() #20 0x57e7304c58dc chromeos::GaiaScreenHandler::ShowGaiaAsync() #21 0x57e72ca0362b chromeos::LoginDisplayHostCommon::ShowGaiaDialogCommon() #22 0x57e72ca04686 chromeos::LoginDisplayHostMojo::ShowGaiaDialog() #23 0x57e72fbfd2ef ash::LoginShelfView::ButtonPressed() #24 0x57e72f27480c views::ButtonController::OnKeyPressed() #25 0x57e72f2c2624 views::View::OnKeyEvent() #26 0x57e72f266a3b ui::ScopedTargetHandler::OnEvent() #27 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #28 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #29 0x57e72e80fd89 ui::EventSource::SendEventToSinkFromRewriter() #30 0x57e72f2cf9e0 views::Widget::OnKeyEvent() #31 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #32 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #33 0x57e72ebb9387 aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x57e72e8381c3 ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x57e72e85f4fd ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent() #36 0x57e72e85f24c ui::InputMethodChromeOS::DispatchKeyEvent() #37 0x57e72ebb217f aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x57e72ebb1a28 aura::WindowEventDispatcher::PreDispatchEvent() #39 0x57e72e80eedd ui::EventDispatcherDelegate::DispatchEvent() #40 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #41 0x57e72e80fece ui::EventSource::EventRewriterContinuationImpl::SendEvent() #42 0x57e72c649a27 ui::EventRewriterChromeOS::RewriteKeyEventInContext() #43 0x57e72c6492fe ui::EventRewriterChromeOS::RewriteEvent() #44 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #45 0x57e72fb88588 ash::KeyboardDrivenEventRewriter::RewriteEvent() #46 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #47 0x57e72fb88e9b ash::SpokenFeedbackEventRewriter::RewriteEvent() #48 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #49 0x57e72fbec429 ash::TouchExplorationController::RewriteEvent() #50 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #51 0x57e72fb5e078 ash::AutoclickDragEventRewriter::RewriteEvent() #52 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #53 0x57e72fbdf76b ash::MagnificationController::RewriteEvent() #54 0x57e72e80fd68 ui::EventSource::SendEventToSinkFromRewriter() #55 0x57e72fb9bb93 aura::WindowTreeHostPlatform::DispatchEvent() #56 0x57e72fb9d8dc ash::AshWindowTreeHostPlatform::DispatchEvent() Change-Id: Ibead7896cecddcb3da8bb4a553137f65700248f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324108 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792662}

This reverts commit 4702a75. Reason for revert: Suspected for causing MSAN failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20123? Sample failure: ==7998==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5562f862015e in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:22)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:932:5 #1 0x5562f862015e in base::ObserverList<arc::ArcSessionManagerObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(arc::ArcSessionManagerObserver const*) ./../../base/observer_list.h:283:9 #2 0x5562f9398e52 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::RemoveAll() ./../../base/scoped_observer.h:67:7 #3 0x5562f9396de0 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::~ScopedObserver() ./../../base/scoped_observer.h:48:5 #4 0x5562f9396d2a in policy::LockToSingleUserManager::~LockToSingleUserManager() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager.cc:79:1 #5 0x5562efbc5122 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #6 0x5562efbc5122 in std::__1::unique_ptr<policy::LockToSingleUserManager, std::__1::default_delete<policy::LockToSingleUserManager> >::reset(policy::LockToSingleUserManager*) ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #7 0x5562efbc46de in policy::LockToSingleUserManagerTest::TearDown() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager_unittest.cc:75:34 #8 0x5562f0ae795a in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5562f0ae9cac in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 Original change's description: > ARCVM SharePath() to use correct seneschal port > > During the processing of ARCVM SharePath() request, it was retrieving > the seneschal port via some Crostini functions. This was incorrect and > would trigger a Crostini restart. This change will properly fix this > by retrieving the correct seneschal port from ArcSessionManagerVmObserver. > > BUG=b:147618164 > TEST=tast run <DUT> arc.Drivefs.vm > > Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 > Commit-Queue: Cherie Cheung <cherieccy@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794973} TBR=hashimoto@chromium.org,yusukes@chromium.org,vasilii@chromium.org,hidehiko@chromium.org,treib@chromium.org,joelhockey@chromium.org,cherieccy@chromium.org Change-Id: I4e35fd26a70f3f74588fb77f1c9e2a210bb19371 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:147618164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339579 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795069}

#1 - Ignore XML namespaces when sorting See https://chromium-review.googlesource.com/c/chromium/src/+/2321522 for an example of where this was causing them to change order. #2 - Prefer to sort by android:name when present Prevents order change when attributes are added/removed. #3 - Don't sort top-level nodes reversed (other than <application>) Bug: 1064151 Change-Id: If552c2c2baa1f538a00d9ddfa3ead6feb19ce6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366038 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#800203}

https://chromium.googlesource.com/vulkan-deps.git/+log/8941374f2873..e0136f0880da Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0c4c93bf61..ae2a562936 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dbd221b2bc..8926213dd0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/71916f15bc..16266c3883 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com,rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com,rharrison@google.com Change-Id: I42c820a20ca9e37d31a7abe14e856cafa68d9565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983510 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#895435}

Thanks to the recent update of the libvpx vp9 rate controller, we can specify the rate control mode, Constant Bitrate (CBR) and Variable Bitrate (VBR). Since our hardware vp9 encoder runs in CBR always, we configure the rate controller CBR. Bug: b:181797390 Test: Build chrome Test: video_encode_accelerator_tests --codec=vp9 on volteer Change-Id: Ic194d48327876d16fe24e0ff22926878df95c7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2981433 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#895436}

This reverts commit e89a55d. Reason for reland: Official build recipes have improved Original change's description: > Revert "Reland #2 "Android: Enable use_debug_fission for official builds"" > > This reverts commit 49606d0. > > Reason for revert: Official builds are taking too long. > > Original change's description: > > Reland #2 "Android: Enable use_debug_fission for official builds" > > > > This reverts commit d4c88d4. > > > > Reason for reland: Fixed in 9ab29d6 > > > > Original change's description: > > > Revert "Reland "Android: Enable use_debug_fission for official builds"" > > > > > > This reverts commit 30f14e9. > > > > > > Reason for revert: official bot breaking > > > https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 > > > > > > Original change's description: > > > > Reland "Android: Enable use_debug_fission for official builds" > > > > > > > > This reverts commit 86befdd. > > > > > > > > Reason for reland: Bugs fixed in other CLs (see issue) > > > > > > > > Original change's description: > > > > > Revert "Android: Enable use_debug_fission for official builds" > > > > > > > > > > This reverts commit 9d3a461. > > > > > > > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > > > > > > > Original change's description: > > > > > > Android: Enable use_debug_fission for official builds > > > > > > > > > > > > Bug: 1122182 > > > > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > > > > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > > > Bug: 1122182,1144538 > > > > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > > > > Commit-Queue: Krishna Govind <govind@chromium.org> > > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#823080} > > > > > > > > Bug: 1122182 > > > > Bug: 1144538 > > > > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#827946} > > > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1122182 > > > Bug: 1144538 > > > Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781 > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#830755} > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1122182 > > Bug: 1144538 > > Change-Id: If770c3864f5c9bf6e90a25bd1985d358d42f2b2a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560912 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#831414} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182 > Bug: 1144538 > Bug: 1153349 > Change-Id: I37a427096c04c4c461170580dc6ded2ae6c2ffd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574436 > Reviewed-by: Ben Mason <benmason@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833738} No-Try: true Bug: 1122182 Bug: 1144538 Bug: 1153349 Change-Id: I798e03f62716880eac4a18010c3c0744edf686d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983445 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#896589}

This reverts commit 4b7834e. Reason for revert: Linux MSAN reports a consisten use-of-uninitialized-value failure: HeapProfilingProtoExporterTest.TraceFormat ==23751==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x56504e3f8ad2 in assign ./../../buildtools/third_party/libc++/trunk/include/__string:320:73 #1 0x56504e3f8ad2 in __init ./../../buildtools/third_party/libc++/trunk/include/string:1865:5 #2 0x56504e3f8ad2 in basic_string<nullptr_t> ./../../buildtools/third_party/libc++/trunk/include/string:835:7 #3 0x56504e3f8ad2 in heap_profiling::HeapProfilingTraceSource::AddToTraceIfEnabled(std::__1::vector<base::SamplingHeapProfiler::Sample, std::__1::allocator<base::SamplingHeapProfiler::Sample> > const&) ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source.cc:112:33 #4 0x56501e6c908e in heap_profiling::(anonymous namespace)::HeapProfilingProtoExporterTest_TraceFormat_Test::TestBody() ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source_unittest.cc:88:44 [...] First full failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/29231/test-results Original change's description: > Add an option to write native heap profiles to trace protos > > The heap profile format is same as the sampling profiler. The heap > profiler reuses code from sampling profiler to write heap profiles. > Adds a proto exporter for heap profiler. The heap profiler writes JSON > profiles to traces currently. If the new command line param is passed, > the proto exporter will additionally add heap profile as protos to > traces. So, in this case it will write the profiles to traces in both > format. In the future changes the heap profiler will stop writing JSON. > > BUG=1228548 > > Change-Id: I9929c20479229c9f14e39f1841d4e0adb50160b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018727 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#902872} Bug: 1228548 Change-Id: Iff29ef031147625fc20bfeacc26749b255213eec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038504 Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#902988}

This reverts commit d6eb63f. Reason for revert: Fix test to initialize allocator type in test samples. This was being used by the code. Original change's description: > Revert "Add an option to write native heap profiles to trace protos" > > This reverts commit 4b7834e. > > Reason for revert: Linux MSAN reports a consisten use-of-uninitialized-value failure: > > HeapProfilingProtoExporterTest.TraceFormat > ==23751==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x56504e3f8ad2 in assign ./../../buildtools/third_party/libc++/trunk/include/__string:320:73 > #1 0x56504e3f8ad2 in __init ./../../buildtools/third_party/libc++/trunk/include/string:1865:5 > #2 0x56504e3f8ad2 in basic_string<nullptr_t> ./../../buildtools/third_party/libc++/trunk/include/string:835:7 > #3 0x56504e3f8ad2 in heap_profiling::HeapProfilingTraceSource::AddToTraceIfEnabled(std::__1::vector<base::SamplingHeapProfiler::Sample, std::__1::allocator<base::SamplingHeapProfiler::Sample> > const&) ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source.cc:112:33 > #4 0x56501e6c908e in heap_profiling::(anonymous namespace)::HeapProfilingProtoExporterTest_TraceFormat_Test::TestBody() ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source_unittest.cc:88:44 > [...] > > First full failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/29231/test-results > > > Original change's description: > > Add an option to write native heap profiles to trace protos > > > > The heap profile format is same as the sampling profiler. The heap > > profiler reuses code from sampling profiler to write heap profiles. > > Adds a proto exporter for heap profiler. The heap profiler writes JSON > > profiles to traces currently. If the new command line param is passed, > > the proto exporter will additionally add heap profile as protos to > > traces. So, in this case it will write the profiles to traces in both > > format. In the future changes the heap profiler will stop writing JSON. > > > > BUG=1228548 > > > > Change-Id: I9929c20479229c9f14e39f1841d4e0adb50160b2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018727 > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#902872} > > Bug: 1228548 > Change-Id: Iff29ef031147625fc20bfeacc26749b255213eec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038504 > Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#902988} Bug: 1228548 Change-Id: I2a48ca4d47123499cb79bd8efb2458ea51aac95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038868 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#905065}

This reverts commit 0d437e0. Reason for revert: Breaks Lacros. [343589:343589:0726/205512.291579:FATAL:sandbox_seccomp_bpf_linux.cc(239)] Check failed: BPFBasePolicy::GetFSDeniedErrno() == (*__errno_location ()) (1 vs. 13) #0 0x7fa2e2e3a8af base::debug::CollectStackTrace() #1 0x7fa2e2baee0a base::debug::StackTrace::StackTrace() #2 0x7fa2e2baedc5 base::debug::StackTrace::StackTrace() #3 0x7fa2e2bfe239 logging::LogMessage::~LogMessage() #4 0x7fa2e2bfe959 logging::LogMessage::~LogMessage() #5 0x7fa2e2b6e5eb logging::CheckError::~CheckError() #6 0x7fa2cc927b2f sandbox::policy::SandboxSeccompBPF::RunSandboxSanityChecks() #7 0x7fa2cc91fc71 sandbox::policy::SandboxLinux::StartSeccompBPF() #8 0x7fa2cc9206fd sandbox::policy::SandboxLinux::InitializeSandbox() #9 0x7fa2d83e65a3 content::(anonymous namespace)::StartSandboxLinux() #10 0x7fa2d83e62b9 content::(anonymous namespace)::ContentSandboxHelper::EnsureSandboxInitialized() #11 0x7fa2a32de13e gpu::GpuInit::InitializeAndStartSandbox() #12 0x7fa2d83e5ca0 content::GpuMain() #13 0x7fa2dbd8a5ad content::RunZygote() #14 0x7fa2dbd8aa3a content::RunOtherNamedProcessTypeMain() #15 0x7fa2dbd8b7b4 content::ContentMainRunnerImpl::Run() #16 0x7fa2dbd889ae content::RunContentProcess() #17 0x7fa2dbd892fd content::ContentMain() #18 0x5588c3250966 ChromeMain #19 0x5588c3250812 main #20 0x7fa2a56aed0a __libc_start_main #21 0x5588c325072a _start To repro the failure, follow go/lacros-build and build linux Lacros. Lacros can't be launched with the failure above. Original change's description: > Use EACCES over EPERM for broker process denied errno > > When dlopen is called without an absolute path, it looks in a number > of search paths for the requested library (e.g. /lib64/libfoo.so, > /usr/lib/libfoo.so). Often, these files don't exist and the > corresponding openat syscall should return ENOENT, but because of > the GPU sandbox, the syscall returns EPERM instead [1]. glibc's > implementation of dlopen, however, early-exits when it sees an > unexpected errno [2] and terminates without attempting the remaining > search paths. Thus, even if the library *is* allowlisted in a later > path, dlopen will still exit with a failure. > > This CL fixes this issue by changing the denied errno to EACCES for > the broker process. > > Bug: 1233028 > Change-Id: I192098eb072f2ee6fb18aa7da3d1998f8328149f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3054490 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#905330} Bug: 1233028 Change-Id: I111ff2bf802615e1299aee7feb88471d49a238e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3055402 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Owners-Override: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#905685}

Update UserSessionInitializer::PreStartSession() to take bool is_primary_session and only call NetworkCertLoader::MarkUserNSSDBWillBeInitialized() when true. Fixes crash: 2021-08-08T22:59:06.505936Z FATAL chrome[21728:21728]: [network_cert_loader.cc(148)] Check failed: state_ == State::kNotInitialized || state_ == State::kMarkedWillBeInitialized. #0 0x57e49567eb89 base::debug::CollectStackTrace() #1 0x57e4955c5c93 base::debug::StackTrace::StackTrace() #2 0x57e48fd06890 logging::LogMessage::~LogMessage() #3 0x57e4955d904e logging::LogMessage::~LogMessage() #4 0x57e497827697 chromeos::NetworkCertLoader::CertCache::MarkWillBeInitialized() #5 0x57e4978277d2 chromeos::NetworkCertLoader::MarkUserNSSDBWillBeInitialized() #6 0x57e4937607ac ash::UserSessionManager::StartSession() #7 0x57e493712814 chromeos::ExistingUserController::OnAuthSuccess() #8 0x57e498a7a9e5 chromeos::LoginPerformer::OnAuthSuccess() #9 0x57e498a72c39 chromeos::CryptohomeAuthenticator::OnAuthSuccess() #10 0x57e490df73f4 base::TaskAnnotator::RunTask() #11 0x57e48fe5bc9d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #12 0x57e4956477c2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x57e4909e2445 base::MessagePumpLibevent::Run() #14 0x57e495647a83 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #15 0x57e49560bb56 base::RunLoop::Run() #16 0x57e4924d69f1 content::BrowserMainLoop::RunMainMessageLoop() #17 0x57e4924d8840 content::BrowserMainRunnerImpl::Run() #18 0x57e4924d3ce8 content::BrowserMain() #19 0x57e495082b38 content::RunBrowserProcessMain() #20 0x57e495083e3b content::ContentMainRunnerImpl::RunBrowser() #21 0x57e4950838c6 content::ContentMainRunnerImpl::Run() #22 0x57e49508123e content::RunContentProcess() #23 0x57e495081c40 content::ContentMain() #24 0x57e4910cf23e ChromeMain #25 0x789c45710e05 __libc_start_main #26 0x57e4910cf0da _start Task trace: #0 0x57e498a73fcc chromeos::CryptohomeAuthenticator::Resolve() #1 0x57e496c95be1 dbus::ObjectProxy::OnPendingCallIsComplete() #2 0x57e496c91b91 dbus::Bus::OnDispatchStatusChanged() #3 0x57e49567fa66 base::FileDescriptorWatcher::Controller::Watcher::OnFileCanReadWithoutBlocking() Change-Id: I4b250f807ca8f3fff35cb380b3a47ce98b7ade09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3080039 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#910647}

…lds""" This reverts commit 0db98a4. Reason for revert: Build failures and subtly incorrect debug info Original change's description: > Reland #3 "Android: Enable use_debug_fission for official builds"" > > This reverts commit e89a55d. > > Reason for reland: Official build recipes have improved Bug: 1239625 Bug: 1241495 Change-Id: Ia9846893884538b7a16efa909ea7f0ed908eeadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111290 Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#914006}

Fix the test helper function waitForWindow() to work for the SWA, by: 1. In the JS for SWA send the messages `findSwaWindow` and `loadSwaTestUtils`to the browser test. 2. In the browser test, scan `BrowserList` to find the Files SWA WebContents. 3. In the browser test: execute, the newly added, test.getSwaAppId() in the WebContents to retrieve the appId. On step #3 the appId is similar to what was in use in the browser test, prior to this CL it was the the SWA URL + the `launchDir`, now it's the `currentDirectoryURL` without the prefix `filesystem:` which results in something like: chrome://file-manager/external/Downloads-user/Downloads/photos Bug: b:194252786 Change-Id: I10cdf9b6b44c955559dd8b93fd5cb279ab77f0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3080580 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Bo Majewski <majewski@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#914185}

This reverts commit 3fa3172. Reason for revert: The CL likely caused service_unittests failures. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40578/test-results [ RUN ] TracingObserverProtoTest.AddChromeDumpToTraceIfEnabled_When_TraceLog_Disabled FATAL services_unittests[31665:31712]: [sequence_checker.h(136)] Check failed: checker.CalledOnValidSequence(&bound_at). #0 0x557c6c97d3db in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4192:13 #1 0x557c7761a0d9 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:867:39 #2 0x557c773a7583 in StackTrace ./../../base/debug/stack_trace.cc:200:12 #3 0x557c773a7583 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:197:28 Original change's description: > [fuchsia] Publish memory usage details to Inspect. > > Set up a "memory" node published by each web_instance, that will gather > details from the instance's processes regarding their memory usage, on- > demand. > > By default this reports the type and Private Memory Footprint of each > process. Additional detail can be included, from named allocator-dumps > specified in an |allocator-dump-names| argument in the web_instance's > config-data. > > Bug: 1238889 > Change-Id: Id517c52650653e1a1dd681a721d845d6bd301545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3094003 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#914113} Bug: 1238889 Change-Id: I4dbc3d2bbc752709c105c4919f7df61ae55fb3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110459 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/main@{#914261}

This reverts commit 85681bf. Reason for revert: Original CL was reverted speculatively to address Linux test failures, despite only affecting Fuchsia. Original change's description: > Revert "[fuchsia] Publish memory usage details to Inspect." > > This reverts commit 3fa3172. > > Reason for revert: The CL likely caused service_unittests failures. > https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40578/test-results > [ RUN ] TracingObserverProtoTest.AddChromeDumpToTraceIfEnabled_When_TraceLog_Disabled > FATAL services_unittests[31665:31712]: [sequence_checker.h(136)] Check failed: checker.CalledOnValidSequence(&bound_at). > #0 0x557c6c97d3db in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4192:13 > #1 0x557c7761a0d9 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:867:39 > #2 0x557c773a7583 in StackTrace ./../../base/debug/stack_trace.cc:200:12 > #3 0x557c773a7583 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:197:28 > > > Original change's description: > > [fuchsia] Publish memory usage details to Inspect. > > > > Set up a "memory" node published by each web_instance, that will gather > > details from the instance's processes regarding their memory usage, on- > > demand. > > > > By default this reports the type and Private Memory Footprint of each > > process. Additional detail can be included, from named allocator-dumps > > specified in an |allocator-dump-names| argument in the web_instance's > > config-data. > > > > Bug: 1238889 > > Change-Id: Id517c52650653e1a1dd681a721d845d6bd301545 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3094003 > > Commit-Queue: Wez <wez@chromium.org> > > Auto-Submit: Wez <wez@chromium.org> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#914113} > > Bug: 1238889 > Change-Id: I4dbc3d2bbc752709c105c4919f7df61ae55fb3cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110459 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Maxim Kolosovskiy <kolos@chromium.org> > Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/main@{#914261} Bug: 1238889 Change-Id: I4052da8a2849379e24cea6bdc883249bbe579679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3113669 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Owners-Override: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/main@{#914285}

Design-doc: https://docs.google.com/document/d/1LHJRt-ry9hwzFTbPxKrmD0VvtEFEU6lvqsD7k6wwGKM Background: Conditional Focus allows a called to getDisplayMedia() to decide whether the captured display surface (tab/window) should be focused. There is a window of 1s during which focus can be triggered or suppressed. If the application does not explicitly decide within the allotted time, the captured display surface IS focused, in line with previous behavior. This CL: Introduce the microtask that closes the focus-window. Thanks to this microtask, a Web-app that does not call focus(), but which does not unreasonably hold up the main thread, would get the default focus-switching behavior in less than a second (the hard-limit on the browser side). Note: This CL does not introduce any new unit-tests or browser-tests. It's easier to check this feature once all parts are landed. This is safe because everything is gated by a command-line flag and is no-op so long as the command-line flag is not provided. Next CLs, in order: 1. Add browser tests. 2. Remove the browser-side command-line flag. 3. Change the Blink feature-gating to OT-gating. Bug: 1215480 Change-Id: I1b3d300c1aca6dadc99a6e53562c2c8689196227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3114286 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#916350}

OnAppTypeInitialized could call observer's OnAppTypeInitialized. Observer's OnAppTypeInitialized might have complex operation to call OnApps, then call OnAppTypeInitialized again, which might cause the dead loop. For example: OnAppTypeInitialized(kWeb) --> FullRestoreAppLaunchHandler::OnAppTypeInitialized(kWeb) --> LaunchBrowser ... -->ExtensionAppsBase::OnExtensionLastLaunchTimeChanged // To change the launch time for Chrome -> OnApps -> OnAppTypeInitialized // in_progress_initialized_app_types_ is not clear yet, // which causes dead loop! -> FullRestoreAppLaunchHandler::OnAppTypeInitialized (kWeb) ..... #3 0x55c927c6c90f apps::ExtensionAppsBase::OnExtensionLastLaunchTimeChanged() #4 0x55c9254a2712 extensions::ExtensionPrefs::SetLastLaunchTime() #5 0x55c92b2a97e4 BrowserShortcutShelfItemController::OnBrowserAdded() Modify OnAppTypeInitialized to clear in_progress_initialized_app_types_ before calling the observer's OnAppTypeInitialized, to prevent observer's OnAppTypeInitialized called again and again. BUG=1237267 Change-Id: Ide98fd1f31afabd5678c6c3c0734913f8d7785bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156647 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#920619}

This reverts commit 4f0f07d. Reason for revert: This is causing failures on the asan/lsan bot. https://bugs.chromium.org/p/chromium/issues/detail?id=1250054 ==7374==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/ranges/algorithm.h:31:10)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:942:5 #1 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:465:10 #2 0x55b1cff1c2ce in find_if<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:483:10 #3 0x55b1cff1c2ce in base::ObserverList<aura::EnvObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(aura::EnvObserver const*) ./../../base/observer_list.h:283:21 #4 0x55b1b16a5284 in Reset ./../../base/scoped_observation.h:69:7 #5 0x55b1b16a5284 in base::ScopedObservation<aura::Env, aura::EnvObserver, &(aura::Env::AddObserver(aura::EnvObserver*)), &(aura::Env::RemoveObserver(aura::EnvObserver*))>::~ScopedObservation() ./../../base/scoped_observation.h:53:26 #6 0x55b1c95200e4 in ash::ArcOverlayManager::~ArcOverlayManager() ./../../ash/public/cpp/external_arc/overlay/arc_overlay_manager.cc:52:1 #7 0x55b1c9520174 in ash::ArcOverlayManager::~ArcOverlayManager() arc_overlay_manager.cc:0:0 #8 0x55b1b0a0deea in operator() ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:54:5 #9 0x55b1b0a0deea in reset ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:315:7 #10 0x55b1b0a0deea in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:269:19 #11 0x55b1b0a0deea in payments::(anonymous namespace)::AndroidPaymentAppFactoryTest::~AndroidPaymentAppFactoryTest() ./../../chrome/browser/payments/android_payment_app_factory_browsertest.cc:29:52 #12 0x55b1b0a10f5c in payments::(anonymous Original change's description: > [Web Payment] App store billing never shows browser UI. > > Before this patch, immediately resolving the promise passed into > PaymentRequest.show() (the so-called "show() promise"), e.g., by calling > PaymentRequest.show(Promise.resolve({})), would have the possibility of > both showing the browser payment sheet and invoking the payment app, > because the code did not expect that the promise would be resolved > faster than enumerating the locally installed payment apps. > > This patch prevents invoking a payment app or showing the browser > payment sheet when the show() promise resolves before the locally > installed payment apps have been enumerated. > > After this patch, immediately resolving the show() promise will not > result in both showing the browser payment sheet and invoking the > payment app at the same time. > > Bug: 1237921 > Change-Id: I132700146d6f9334a5c56d136f80fcdc62873313 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160759 > Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#921617} Bug: 1237921 Change-Id: I8a1e6c7c6080b175d180d4c37d2fbc3d7eb77af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163453 Auto-Submit: Scott Violet <sky@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/main@{#921917}

(CFFU is short for "Conditional Focus Follow-Ups") In response to updates in the design-doc: * FMST::clone() now returns an FMST object, not MST. * Calling focus() on a clone raises an exception. This change allows FocusableMediaStreamTrack to be subclassed further without clones suffering from having non-focus functionality stripped away. For a likely future inheritance tree, see here: https://docs.google.com/presentation/d/1dwgo4N86CriLrRLjVCD5nFDsq_OC8GNALAtCA7e0pIo/edit#slide=id.gef5c89d116_0_662 Bug: 1215480 Change-Id: I6fe7fb85c76826d3f296b86821184f26c721c277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3164982 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#923299}

This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}

… CrosState" This reverts commit 3895114. Reason for revert: likely cause of failures Step "chromeos_components_unittests on Ubuntu-18.04" failing on builder "Linux Chromium OS ASan LSan Tests (1)" The first run with the relevant failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40730/overview The following tests consistently fail starting after this first run: CrosStateSenderTest.NotificationFeatureStateChanged CrosStateSenderTest.PerformUpdateCrosStateRetrySequence The first fails with this stack trace: --- [ RUN ] CrosStateSenderTest.NotificationFeatureStateChanged ================================================================= ==4136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700004b31c at pc 0x5559c16fed11 bp 0x7fffb87b9250 sp 0x7fffb87b9248 READ of size 4 at 0x60700004b31c thread T0 #0 0x5559c16fed10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5559ce6da0ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5559ce6d9e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5559c17102b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5559ba7314dc in chromeos::phonehub::CrosStateSenderTest_NotificationFeatureStateChanged_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:146:29 #5 0x5559baf612a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5559baf612a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7f002b751bf6 in __libc_start_main ??:0:0 0x60700004b31c is located 4 bytes to the right of 72-byte region [0x60700004b2d0,0x60700004b318) allocated by thread T0 here: #0 0x5559ba47faed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5559c14ad498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5559c14ad498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5559c14ad498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5559c16fdfe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5559c16fdfe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5559c16fdfe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5559d736b57e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5559ba733ad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5559ba733ad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5559baf6118e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5559baf6118e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7f002b751bf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80001610: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fa fa 0x0c0e80001620: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e80001630: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80001640: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80001650: fd fd fd fd fd fd fa fa fa fa 00 00 00 00 00 00 =>0x0c0e80001660: 00 00 00[fa]fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80001670: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x0c0e80001680: fa fa fa fa 00 00 00 00 00 00 00 00 00 00 fa fa 0x0c0e80001690: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e800016a0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 0x0c0e800016b0: 00 00 00 00 00 00 00 00 fa fa fa fa 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==4136==ABORTING --- The second fails with this one: --- [ RUN ] CrosStateSenderTest.PerformUpdateCrosStateRetrySequence ================================================================= ==3811==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700005f9ec at pc 0x5579c6175d11 bp 0x7ffd5e6a0e10 sp 0x7ffd5e6a0e08 READ of size 4 at 0x60700005f9ec thread T0 #0 0x5579c6175d10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5579d31510ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5579d3150e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5579c61872b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5579bf1a3085 in chromeos::phonehub::CrosStateSenderTest_PerformUpdateCrosStateRetrySequence_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:63:29 #5 0x5579bf9d82a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5579bf9d82a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7fc58b24bbf6 in __libc_start_main ??:0:0 0x60700005f9ec is located 4 bytes to the right of 72-byte region [0x60700005f9a0,0x60700005f9e8) allocated by thread T0 here: #0 0x5579beef6aed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5579c5f24498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5579c5f24498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5579c5f24498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5579c6174fe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5579c6174fe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5579c6174fe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5579dbde257e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5579bf1aaad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5579bf1aaad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5579bf9d818e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5579bf9d818e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7fc58b24bbf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80003ee0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80003ef0: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80003f00: fd fd fd fd fd fd fa fa fa fa fd fd fd fd fd fd 0x0c0e80003f10: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80003f20: fd fd fa fa fa fa fd fd fd fd fd fd fd fd fd fd =>0x0c0e80003f30: fa fa fa fa 00 00 00 00 00 00 00 00 00[fa]fa fa 0x0c0e80003f40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==3811==ABORTING --- Original change's description: > [CameraRoll]Send camera roll setting to the Android device in CrosState > > Include camera roll setting state as part of CrosState, > so connected mobile device would be able to get update > when setting value is toggled. > > Change-Id: I04d0ed3872d5adeff5e8f8dc76c6eb6df3a50b9c > Bug: https://crbug.com/1221297 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173740 > Commit-Queue: Jianbing Wu <jianbing@google.com> > Auto-Submit: Jianbing Wu <jianbing@google.com> > Reviewed-by: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924995} Bug: https://crbug.com/1221297 Change-Id: Ic87d96786b4244b27b1e284f801df8799911b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184482 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#925118}

This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}

Sub-classing WKNavigationResponse appear to cause crashes in the method -dealloc when running the CRWWebControllerResponseTest.* tests individually (at least on iOS 15.0 simulator). The crash looks like this when running `ios_web_unittests` with `--gest_filter=*.DownloadRendererInitiatedDataUrlResponseInMainFrame`: [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from CRWWebControllerResponseTest [ RUN ] CRWWebControllerResponseTest.DownloadRendererInitiatedDataUrlResponseInMainFrame (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x30) frame #0: 0x00007fff334ff702 JavaScriptCore`WTF::RunLoop::dispatch(WTF::Function<void ()>&&) + 34 frame #1: 0x00007fff2aa131e4 WebCore`WebCoreObjCScheduleDeallocateOnMainRunLoop(objc_class*, objc_object*) + 68 frame #2: 0x00007fff297645a9 WebKit`-[WKNavigationResponse dealloc] + 37 frame #3: 0x00007fff2019c9f7 libobjc.A.dylib`objc_object::sidetable_release(bool, bool) + 177 * frame #4: 0x000000010602060f ios_web_unittests`web::CRWWebControllerResponseTest::CallDecidePolicyForNavigationResponseWithResponse(this=0x00007fc002b06a70, response=0x000060000008ce40, for_main_frame=YES, can_show_mime_type=YES, out_policy=0x00007ffee9d27238) at crw_web_controller_unittest.mm:553:3 frame #5: 0x0000000106021041 ios_web_unittests`web::CRWWebControllerResponseTest_DownloadRendererInitiatedDataUrlResponseInMainFrame_Test::TestBody(this=0x00007fc002b06a70) at crw_web_controller_unittest.mm:613:3 frame #6: 0x0000000106539c3b ios_web_unittests`void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(object=0x00007fc002b06a70, method=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, location="the test body")(), char const*) at gtest.cc:2631:10 Instead use OCMock to create a mock and to stub the values returned by the WKNavigationResponse properties' accessor. This fixes the crash as no WKNavigationResponse are created and thus the destructor is no longer called). Bug: none Change-Id: I063b3d52af2b91d57f0a08d6799c08eba908a3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3186913 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#925317}

The sequence of events: 1) Page A starts a prerender to page B 2) Page B creates an AsyncDocumentSubresourceFilter for its main RFH 3) Page B navigates a cross-origin subframe 4) Because it's cross-origin in a prerender, the PrerenderSubframeNavigationThrottle defers the subframe navigation at WillStartRequest. 5) The user now navigates to page B causing a prerender activation 6) The prerender activation creates a main frame, cross-document navigation in the primary frame tree. This doesn't run navigation throttles but the ContentSubresourceFilterThrottleManager sees this as a regular navigation in the main frame and creates a new AsyncDocumentSubresourceFilter for the navigation's RFH. Because prerendering activation only moves a page from the prerender frame tree into the primary frame tree, the RFH is preserved so this is the same RFH as in step #2 7) CSFTM keeps track of AsyncDocumentSubresourceFilters in a RFH->Filter map. So the new filter overwrites the one created in step #2. This deletes the first filter since the map owns it. 8) Now that the prerendering page has entered the primary frame tree, the subframe navigation from step #4 is resumed. 9) The subframe navigation runs the SubframeNavigationFilteringThrottle, which was created in step #3 and has a raw pointer to the AsyncDocumentSubresourceFilter from step #2. However, this filter was deleted in step #7 so this points to freed memory. The throttle calls a method on this bad pointer and we eventually crash somewhere. This issue is fixed in https://crrev.com/c/3018307 by making each throttle manager responsible for a single page. This CL only adds a test for this specific situation. A small note about the test, we changed from registering throttles in DidStartNavigation to the ContentBrowserClient. RegisterThrottleForTesting adds throttles to the end of the throttle runner which meant we run a different throttle ordering in tests. In particular, the reproduction required that the SubframeNavigationFilteringThrottle run WillStartRequest before being blocked on prerendering in step #4, before the filter was overwritten. Using RegisterThrottleForTesting meant it would only be run after the prerender was activated. Bug: 1203614 Change-Id: I24ab77a04b9032933cfa45a167145139465c58ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033462 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/main@{#926616}

…renderer initiated, attempt #3 Currently, all history navigations are considered browser-initiated, even if they are initiated via the javascript history API. However, there are some use cases where it would be good to know where the history navigation came from. There are several callsites that assume all history navigations are browser-initiated, so update those. Also, a few DCHECKs are no longer valid, because they assume that a renderer-initiated navigation will always have an initiator origin. Now, if a renderer-initiated history navigation goes back/forward to an entry that was originally browser-initiated, a renderer-initiated navigation can have no initiator origin. Attempt #1: https://chromium.googlesource.com/chromium/src/+/5d955f77c66a4bd5c677726ede44e219d99d5eeb Attempt #2: https://chromium.googlesource.com/chromium/src/+/cc0d5f46ffdffbd2245aaa9456d124713b1c2e1a Only changes between this and attempt #2 are a fix for DisableExtensionBrowserTest.VisitReenabledExtensionInSubframe, and a compile fix in content/browser/renderer_host/isolated_app_throttle_unittest.cc Bug: 1127317, 1245636 Change-Id: I4e919fecc873d878dd186897a3909c2438d0aab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187574 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Nate Chapin <japhet@chromium.org> Owners-Override: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#926831}

This reverts commit cc5a8ac. Reason for revert: Test crashes on Android Pie bot Sample failing test run https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/6303 Original change's description: > [MPArch] Test prerendering crash in subresource filter > > The sequence of events: > > 1) Page A starts a prerender to page B > 2) Page B creates an AsyncDocumentSubresourceFilter for its main RFH > 3) Page B navigates a cross-origin subframe > 4) Because it's cross-origin in a prerender, the > PrerenderSubframeNavigationThrottle defers the subframe navigation > at WillStartRequest. > 5) The user now navigates to page B causing a prerender activation > 6) The prerender activation creates a main frame, cross-document > navigation in the primary frame tree. This doesn't run navigation > throttles but the ContentSubresourceFilterThrottleManager sees this > as a regular navigation in the main frame and creates a new > AsyncDocumentSubresourceFilter for the navigation's RFH. Because > prerendering activation only moves a page from the prerender frame > tree into the primary frame tree, the RFH is preserved so this is > the same RFH as in step #2 > 7) CSFTM keeps track of AsyncDocumentSubresourceFilters in a > RFH->Filter map. So the new filter overwrites the one created in > step #2. This deletes the first filter since the map owns it. > 8) Now that the prerendering page has entered the primary frame tree, > the subframe navigation from step #4 is resumed. > 9) The subframe navigation runs the > SubframeNavigationFilteringThrottle, which was created in step #3 > and has a raw pointer to the AsyncDocumentSubresourceFilter from > step #2. However, this filter was deleted in step #7 so this points > to freed memory. The throttle calls a method on this bad pointer and > we eventually crash somewhere. > > This issue is fixed in https://crrev.com/c/3018307 by making each > throttle manager responsible for a single page. This CL only adds a test > for this specific situation. > > A small note about the test, we changed from registering throttles in > DidStartNavigation to the ContentBrowserClient. > RegisterThrottleForTesting adds throttles to the end of the throttle > runner which meant we run a different throttle ordering in tests. In > particular, the reproduction required that the > SubframeNavigationFilteringThrottle run WillStartRequest before being > blocked on prerendering in step #4, before the filter was overwritten. > Using RegisterThrottleForTesting meant it would only be run after the > prerender was activated. > > Bug: 1203614 > Change-Id: I24ab77a04b9032933cfa45a167145139465c58ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033462 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926616} Bug: 1203614 Change-Id: I867c0641701cde250e9c3860dc787a4c32b4a81d Owners-Override: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199971 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927378}

…ch providers."." This reverts commit 23f829c. Reason for revert: Breaks TranslateManagerRenderViewHostTest.BubbleUnknownLanguage on linux-chromeos-chrome [ RUN ] TranslateManagerRenderViewHostTest.BubbleUnknownLanguage Received signal 11 SEGV_MAPERR 000000000108 #0 0x56400916c589 base::debug::CollectStackTrace() #1 0x5640090da7c3 base::debug::StackTrace::StackTrace() #2 0x56400916c0df base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fc34d615980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x56400acc1794 TemplateURLService::GetDefaultSearchProvider() #5 0x564009765d6a RenderViewContextMenu::IsRegionSearchEnabled() #6 0x564009762d17 RenderViewContextMenu::AppendPageItems() #7 0x564009762838 RenderViewContextMenu::InitMenu() #8 0x56400886430c RenderViewContextMenuBase::Init() #9 0x5640034ae263 translate::(anonymous namespace)::TranslateManagerRenderViewHostTest_BubbleUnknownLanguage_Test::TestBody() ... Original change's description: > Reland "Add region search support for non-Google default search providers.". > > This an attempted reland of the following reverted change: > https://chromium-review.googlesource.com/c/chromium/src/+/3199698 > > PS1 is identical to the original change with a few minor modifications to resolve merge conflicts. > > The changes from the original is the adding of an instance variable to LensRegionSearchController representing whether the default search engine is Google. This could not be used in the controller directly due to an include rule. This is now instead passed as part of the Start() function through render_view_context_menu. > > > Bug: 1255702,1255897, b/198833501 > Change-Id: I83c4b0a5728ab3ba122d248c05c2f27b76a05a4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203970 > Commit-Queue: Juan Mojica <juanmojica@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ben Goldberger <benwgold@google.com> > Cr-Commit-Position: refs/heads/main@{#928974} Bug: 1255702,1255897, b/198833501 Change-Id: I1bf2e732ac781a5708f4a319ecf5df960239a860 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210916 Auto-Submit: Timothy Loh <timloh@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Owners-Override: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/main@{#929066}

Reasons: 1. no one appears to be using this in any analyses 2. not signed-in could mean different things: - UMA log happened to be closed while the login screen was open; no one had logged in yet. - UMA log happened to be closed while the user was logged in during a guest session. 3. class this inherits from is going to be renamed to Sync Status Metrics Provider, as that's what it actually computes on all those platforms. It's only on ChromeOS that it measure sign-in* (which happens because sign-in == sync on ChromeOS). It will be confusing if this Sign-In Status Metrics Provider inherits from a Sync Status Metrics Provider, as the terminology will constantly be inconsistent. Also, even if we changed the name of this provider to ChromeOS Sync Status Metrics Provider, would also be confusing, as the internals of the class look at sign-in state; it doesn't check sync status. Largely I think this should be deleted for reasons #1 and #2. Reason #3 is more about why it's not worth the trouble of keeping it around in some form. It can also be re-created--a Metrics Provider is not a difficult structure to implement--if something in this area turns out to be useful again later. * mostly; there may be edge case Bug: 1245997 Change-Id: I583639c5a9e554082457575eaee51211ae7f4219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206593 Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#930877}

Collect simple metrics on utilization of numeric pads on different categories of keyboard-like devices. Reland #1,2: with restrictions to only enable specifically for ChromeOS ash, so we don't try to depend on feature_usage_metrics from the Linux targets of Chromium or from the ChromeOS Lacros build. Reland #3: fix usage of removed time-keeping method. Bug: b:184298258 Test: ./out/Debug/events_unittests --gtest_filter=NumberpadMetrics* Test: Validated on Drobit and Woomax with internal keyboards, external Test: wide keyboard, external numberpads, and Drobit dynamic numperpad. Change-Id: Ief3b3316a9667b756dfe03957081b2074e2b1fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198823 Reviewed-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Kenneth Albanowski <kenalba@google.com> Cr-Original-Original-Commit-Position: refs/heads/main@{#928213} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213464 Auto-Submit: Kenneth Albanowski <kenalba@google.com> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#931290} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224039 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/main@{#931636}

This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}

… off" This reverts commit 7db902d. Reason for revert: [sheriff] suspected to cause multiple AccountProfileMapperTest failures on linux-lacros-tester-rel: First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/16078 Sample failure: [ RUN ] AccountProfileMapperTest.RemovePrimaryAccountFromPrimaryProfile Received signal 11 SEGV_MAPERR 209300000105 #0 0x5584a2716cd9 base::debug::CollectStackTrace() #1 0x5584a2684db3 base::debug::StackTrace::StackTrace() #2 0x5584a2716823 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9750773980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x5584a269ec4c base::internal::WeakReference::IsValid() #5 0x55849d569978 base::ObserverList<>::RemoveObserver() #6 0x5584a2edaf01 ProfileAccountManager::Shutdown() #7 0x5584a377e0bc DependencyManager::PerformInterlockedTwoPhaseShutdown() #8 0x5584a1be43ae TestingProfile::~TestingProfile() #9 0x55849cf239ae (anonymous namespace)::PermissionManagerTestingProfile::~PermissionManagerTestingProfile() #10 0x5584a2d094bf ProfileDestroyer::DestroyOriginalProfileNow() #11 0x5584a2d091ed ProfileDestroyer::DestroyProfileWhenAppropriate() #12 0x5584a2d1a886 ProfileManager::ProfileInfo::~ProfileInfo() #13 0x5584a1be6fef std::__1::__tree<>::destroy() #14 0x5584a2d1ca09 ProfileManager::~ProfileManager() #15 0x5584a1be14ae FakeProfileManager::~FakeProfileManager() #16 0x5584a1be5d12 TestingProfileManager::~TestingProfileManager() #17 0x55849dc1309b AccountProfileMapperTest_GetAccounts_Test::~AccountProfileMapperTest_GetAccounts_Test() #18 0x55849ef2f92c testing::TestInfo::Run() #19 0x55849ef30617 testing::TestSuite::Run() Original change's description: > [Lacros] Do not create AccountProfileMapper if the feature is off > > AccountProfileMapper should only be created if the > kMultiProfileAccountConsistency feature is enabled. Otherwise, it might > have negative side-effects like deleting user profiles. > > To add a DCHECK(kMultiProfileAccountConsistency) to > AccountProfileMapper, > this CL also enables kMultiProfileAccountConsistency in all related > unit tests. This appears to be a non-trivial task because ProfileManager > will now create its own instance of AccountProfileMapper that doesn't > use an AccountManagerFacade mock. > > This CL adds a TestingProfileManager::SetAccountProfileMapper() methods > to inject a fake instance for testing. > > Bug: 1226045 > Change-Id: I69f74aed3f4bd9bdb107912d5e92872d53691a07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222809 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#931942} Bug: 1226045 Change-Id: If5ee60910f6cba1aabc407dba814448f538a2d39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227179 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932071}

Bug: 1247761 Change-Id: Ie334af091de48e0ba7fad4486fd8d65139f97ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222948 Auto-Submit: Elad Alon <eladalon@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#932470}

RTCPeerConnectionIceErrorEvent.hostCandidate was marked as deprecated in commit 72c1e71 "Replace hostCandidate with address and port in RTCPeerConnectionIceErrorEvent". Unfortunately the patch did not provide any deprecation message for the feature. As result of this any page using this deprecated functionality will trigger the following DCHECK: [355328:1:0721/120654.530860:9505576756:FATAL:deprecation.cc(743)] Check failed: !info.message.IsEmpty(). #0 0x55c97295dd69 base::debug::CollectStackTrace() #1 0x55c97289f6d3 base::debug::StackTrace::StackTrace() #2 0x55c9728b99d6 logging::LogMessage::~LogMessage() #3 0x55c9728ba46e logging::LogMessage::~LogMessage() #4 0x55c9740389fa blink::Deprecation::CountDeprecation() #5 0x55c97572dd1d blink::(anonymous namespace)::v8_rtc_peer_connection_ice_error_event::HostCandidateAttributeGetCallback() Change-Id: I3f992b802e54d469aaab5bfa68da32e505a48319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041592 Auto-Submit: Piotr Tworek <ptworek@vewd.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#933993}

Overall feature: ---------------- Region Capture is a feature allowing the cropping of self-capture video tracks to track the coordinates of an HTMLElement in the browsing context. Public design-doc: https://docs.google.com/document/d/1dULARMnMZggfWqa_Ti_GrINRNYXGIli3XK9brzAKEV8/edit?usp=sharing Spec draft (very WIP): https://eladalon1983.github.io/region-capture/ (This will be finished soon and moved to the WICG; hopefully to be eventually adopted by the W3C.) This CL: -------- This patch includes the compositor and blink paint system changes necessary to support region capture. Now that elements have a crop identifier, this patch uses the crop ID to propagate bounds down to the CC layer. Next CLs: --------- From here, the render surface implementation will have to grab the bounds from the originating layer and plumb them to the capturer. Bug: 1247761, 1254424 Change-Id: I3851168aa14cd8d637d544ab97256a3d8ec1185b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199051 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#934060}

aarongable force-pushed the master branch from 0c99739 to 455eacb Compare August 9, 2018 19:36

aarongable force-pushed the master branch from 72511a7 to 1dc32ae Compare February 28, 2019 16:58

chromium-autoroll and others added 2 commits June 24, 2021 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE #3

DO NOT MERGE #3

Yannic commented Jul 19, 2018

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019

DO NOT MERGE #3

Are you sure you want to change the base?

DO NOT MERGE #3

Conversation

Yannic commented Jul 19, 2018

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019

autoyannic commented Mar 13, 2019