finalize 2.15.0 #1331
Merged
finalize 2.15.0 #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hitenkoku Sorry, could you check why this is failing? https://github.com/Yamato-Security/hayabusa/actions/runs/8761069797 |
fukusuket
reviewed
Apr 20, 2024
There was a problem hiding this comment.
This seems to be caused by the following changes :(
(It was probably compiled with 0.11.0 before, and now it's compiled with 0.10.x)
- https://github.com/console-rs/dialoguer/blob/master/CHANGELOG.md#breaking
- Remove
ColorfulTheme.inline_selectionsconsole-rs/dialoguer#277
In my environment, the issue was resolved by upgrading to version 0.11 or higher as shown below!
- https://github.com/Yamato-Security/hayabusa/blob/finalize-2.15.0/Cargo.toml#L22
dialoguer = "0.11.*"
|
@fukusuket Thanks! It still wasn't working just by updating dialoguer in Hayabusa for me but when I updated it in hayabusa-evtx it now compiles without any error. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
fukusuket
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hitenkoku @fukusuket I decided to release 2.15.0 with the
windashsupport to give people time to upgrade before we stop doing thewindashconversion on the backend.