Switch to new trivy-operator and trivy-server #953
Conversation
CalleB3
changed the title
This reverts commit 50986bc.
| %{~ if provider == "aws" ~} | ||
| serviceAccount: | ||
| annotations: | ||
| eks.amazonaws.com/role-arn: ${trivy_operator_role_arn} |
There was a problem hiding this comment.
Hmm isn't there a service account created for the trivy server?
You will probably need to use var.trivy_role_arn this because the role that gets created is specific to the serviceAccount.
You might also need to update the role_arn to match the new serviceAccount that gets created by the oeprator.
There was a problem hiding this comment.
From what i can tell, trivy-server uses the SA created for trivy-operator.
What do you mean with "update the role_arn to match the new serviceAccount that gets created by the oeprator." Which role is this?
There was a problem hiding this comment.
Currently there are 2 arn's,trivy_operator_role_arn and trivy_role_arn.
There should be no use for both?
There was a problem hiding this comment.
Ahh okay if there is only one SA, you can remove the one called trivy_role_arn just as you say.
terraform-modules/modules/aws/eks/iam.tf
Line 248 in 1aff96b
Good job
|
Fixes #941 |
|
Support for EKS has been deprecated. Furthermore, we are already running the trivy-operator. Closing this. |
This needs to be verified in AWS before merging