Fix DNS Zones variable naming #867
Open
+47
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/dns-zone
branch
4 times, most recently
from
a904d2f
to
35acb7f
Compare
phillebaba
force-pushed
the
fix/dns-zone
branch
from
35acb7f
to
0a54b64
Compare
NissesSenap
approved these changes
Nov 21, 2022
| @@ -15,16 +15,16 @@ locals { | |||
| "velero", | |||
| "promtail" | |||
| ] | |||
| dns_zone = { | |||
| route53_zones = { | |||
There was a problem hiding this comment.
Hmm why don't you want to use dns zones any more?
From my point of view we are working with the construct of dns zones, not a specific product.
I can live with it but just a thought.
There was a problem hiding this comment.
Because this local variable does not represent dns_zones as in all other uses. Its an iteration of Route53 zone ids. Having the same name would confuse more than it helps. Giving it a different name makes it clear that it contains other data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes variable naming to be plural when dns zones are a list.