Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat! migrate remaining platform modules to azure workload identity #1103

Merged
merged 24 commits into from
May 14, 2024

Conversation

landerss1
Copy link
Contributor

This PR migrates the following platform modules to azure workload identity:

  • control-plane-logs
  • prometheus
  • promtail
  • trivy
  • velero

Furthermore, the related managed identities and other resources needed by the kubernetes module have been moved from the aks and aks-regional modules to the corresponding kubernetes module in order to eliminate external dependencies and reduce code complexity.

@landerss1 landerss1 requested a review from CalleB3 May 13, 2024 12:32
CalleB3
CalleB3 previously approved these changes May 13, 2024
Copy link
Member

@CalleB3 CalleB3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@landerss1 landerss1 requested a review from CalleB3 May 14, 2024 07:45
Copy link
Member

@CalleB3 CalleB3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@landerss1 landerss1 merged commit 8fd154b into main May 14, 2024
6 checks passed
@landerss1 landerss1 deleted the migrate-to-workload-identity branch May 14, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants