ad-login extension template copy #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabracadabra
force-pushed
the
adextension
branch
from
a6c42da
to
8e7af9a
Compare
bittrance
previously approved these changes
Apr 25, 2023
|
|
||
| # ad_group_owners = ["user.name@example.com", "user.name_2@example_2.com"] | ||
| data "azuread_users" "ad_group_owners" { | ||
| user_principal_names = var.ad_group_owners |
There was a problem hiding this comment.
Would it not be better to create a nonsense user principal and set it as owner?
There was a problem hiding this comment.
Yes, something similar to managed identity or service principle shall be implemented in a future version.
| @@ -16,15 +16,12 @@ module "linux_adextension" { | |||
| version = "test" | |||
| caching = "test" | |||
| storage_account_type = "SSD" | |||
| disk_size_gb = 128 | |||
| disk_size_gb = 64 | |||
There was a problem hiding this comment.
This is declared as an optional string. Why does this not fail?
There was a problem hiding this comment.
Number vs String in module, could be int32., will modify the variables.tf
There was a problem hiding this comment.
Number vs String in module, could be int32.
| @@ -6,7 +6,7 @@ resource "azurerm_linux_virtual_machine" "vm" { | |||
| } | |||
| name = "vm-${var.environment}-${var.location_short}-${each.value.vm_name}" | |||
| location = var.location | |||
| resource_group_name = each.value.rg_name | |||
| resource_group_name = var.rg_name | |||
There was a problem hiding this comment.
Nitpick: This should be azurerm_resource_group.rg.name. Some more below.
yabracadabra
force-pushed
the
adextension
branch
from
57b0057
to
c48b343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.