Add "version" argument to "installed" function, printing Xcode's installation path #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerluan
added a commit
to fastlane/fastlane
that referenced
this pull request
Sep 21, 2022
…issions. - Depends on XcodesOrg/xcodes#220
5 tasks
MattKiazyk
approved these changes
Sep 29, 2022
revolter
pushed a commit
to fastlane/fastlane
that referenced
this pull request
Nov 2, 2022
…issions. - Depends on XcodesOrg/xcodes#220
joshdholtz
pushed a commit
to fastlane/fastlane
that referenced
this pull request
Nov 12, 2022
…all` (#20672) * Move helpers to a separate and centralized file. * Deprecate 'xcode-install' gem (the project has been sunset), adding 'xcodes' action to replace the 'xcode_install' one. * Add 'select_only' option to 'xcodes', deprecating 'xcversion' action. * Update documentation to state it also supports .xcode-version file. * Add TODO for a future improvement. * Lint. * Fix link. * Remove TODO comment. * Lint. * Fix typo in error being raised. * Add ability to select Xcode just for current build, without sudo permissions. - Depends on XcodesOrg/xcodes#220 * Update documentation to point to 'xcodes' instead. * Update xcodes link. * Apply suggestions from code review. Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com> * Change "#" by "." in spec descriptions, to indicate class methods. * Apply suggestion from code review. * Improve documentation around requirements to run xcodes. * Remove necessity to authenticate with Apple servers since xcodes v1.0.0. * Use new --update and --selected arguments, which require xcodes v1.1.0. * Fix comparing Gem::Version with String error * Remove unused local variable * Split long lines * Fix lint issues * Address style comments. * Remove superfluous trailing slash This makes it consistent with the rest of the codebase. * Fix unsafe paths concatenation * Fix some WWDR certificates test failure This was caused by the fact that that test calls a method that uses `$?` (https://stackoverflow.com/a/6834572/865175), which, somehow, (I think) was executed right after a call to XcodesHelper's `find_xcodes_binary_path` method. This latter one returned a non-zero code, because `xcodes` can't be installed on Ubuntu, which got picked up by the certificates return code check, so it treated its actual command as failed. * Replace `Actions.sh` call with a native one (reverted from commit 11bd750) * Fix error-prone shell command status check In the case of the tests, `$?` was not mocked, so it looks like it was indeed just a coincidence that it worked. Meaning, some other shell command that somehow was actually executed (so it wasn't stubbed) succeeded, which caused the `$?.success?` to succeed too. Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com> Co-authored-by: Iulian Onofrei <iulian.onofrei@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #219
This is another initiative that powers xcpretty/xcode-install#467
With the resolution of #219, we can have a smoother transition from
xcode-installtoxcodes, including on fastlane integrations.See also: fastlane/fastlane#20672
Manual Tests Run