fix: fix typing of from_dict and other classmethods
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JST5000
reviewed
Jun 16, 2022
khancode
approved these changes
Jun 16, 2022
mvadari
force-pushed
the
inheritance-types
branch
from
0c4925a
to
3b9590c
Compare
mvadari
force-pushed
the
inheritance-types
branch
from
3b9590c
to
cd8574d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR uses
TypeVarto make the typing offrom_dictand other similar constructor class methods work as expected.Context of Change
I was getting really annoyed by it - it required a lot of unnecessary
casts.Type of Change
Test Plan
mypy passes.