-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add final balances parser #398
Merged
Merged
+535
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
JST5000
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small naming changes, but logic looks good to me :)
JST5000
reviewed
Jun 14, 2022
JST5000
reviewed
Jun 14, 2022
JST5000
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
ckniffen
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
get_final_balances
_compute_final_balance
NormalizedNode
BalanceChange
toComputedBalance
BalanceChanges
toComputedBalances
Context of Change
The #342 PR was splitted. For each exported function (get_balance_changes (already merged #383), get_final_balances, get_previous_balances and get_order_book_changes) there will now be a separate PR to make it easier to review. This PR adds the functionality to parse the final balances from a transaction's metadata (get_final_balances).
Type of Change
Test Plan
I added tests that are testing the same transactions as
get_balance_changes
.