Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export SubscribeBook request model #395

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

khancode
Copy link
Collaborator

High Level Overview of Change

Export SubscribeBook request model.

Context of Change

SubscribeBook can't be imported because it's not exported in xrpl/models/requests/__init__.py.

#394

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Verified unit tests still pass.

@khancode khancode merged commit 4edcfba into master Jun 1, 2022
@khancode khancode deleted the export-subscribe-book branch June 1, 2022 15:06
@mvadari mvadari linked an issue Jun 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubscribeBook should be accessible directly from xrpl.models
3 participants