Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test case for valid client URL #389

Merged
merged 5 commits into from
May 13, 2022
Merged

add test case for valid client URL #389

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9531039
add better error handling for invalid client URLs
khancode May 11, 2022
11f158d
raise XRPLRequestFailureException when response can't be JSON decoded
khancode May 12, 2022
e3656b9
remove valid URL test case
khancode May 13, 2022
78d2a85
add test case for valid client URL
khancode May 13, 2022
4832233
Merge branch 'master' into handle-invalid-url
khancode May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/unit/clients/test_json_rpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
class TestJsonRpcClient(TestCase):
"""Test json_rpc_client."""

def test_json_rpc_client_valid_url(self: TestJsonRpcClient) -> None:
# Valid URL
JSON_RPC_URL = "https://s.altnet.rippletest.net:51234/"
client = JsonRpcClient(JSON_RPC_URL)
client.request(ServerInfo())

def test_json_rpc_client_invalid_url(self: TestJsonRpcClient) -> None:
# Invalid URL
JSON_RPC_URL = "https://s2.ripple.com:51233/"
Expand Down