add better error handling for invalid client URLs #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add better error handling for invalid client URLs.
Context of Change
If you put in the wrong URL of a node for a client, the error that it returns is super opaque (it's a
JSONDecodeError
). We should return a better error/error message, so that it's clear that the user entered the wrong URL for the node.This change now raises an
XRPLRequestFailureException
if the response can't be JSON decoded (JSONDecodeError
).#353
Type of Change
Test Plan
Added unit tests.