Verify submitted transaction is not malformed before waiting for its final outcome. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting for final tx outcome
mvadari
reviewed
Apr 25, 2022
mvadari
reviewed
Apr 25, 2022
mvadari
reviewed
Apr 25, 2022
khancode
changed the title
mvadari
approved these changes
Apr 25, 2022
khancode
changed the title
ckniffen
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Inside
send_reliable_submission, verify submitted transaction is not malformed before waiting for its final outcome.Context of Change
There's a bug in
send_reliable_submissionreported by users where it throws antxnNotFound: Transaction not found exception; Issue1, Issue2. From my investigation, this bug is reproduced when waiting for the final outcome on a submitted malformed transaction (temMALFORMED). Therefore, this fix verifies a submitted transaction is not malformed before waiting for its final outcome insidesend_reliable_submission.Type of Change
Test Plan
Integration and unit tests pass.