Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test case for valid client URL #389

Merged
merged 5 commits into from May 13, 2022
Merged

add test case for valid client URL #389

merged 5 commits into from May 13, 2022

Conversation

khancode
Copy link
Collaborator

High Level Overview of Change

Adds test case for valid client URL. Extension of this PR - #388

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Adds test case for valid client URL.

@khancode khancode requested review from mvadari and JST5000 May 13, 2022 20:29
@khancode khancode merged commit 44b71c4 into master May 13, 2022
@khancode khancode deleted the handle-invalid-url branch May 13, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvadari mvadari mvadari approved these changes

@JST5000 JST5000 JST5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khancode @mvadari @JST5000