Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python code sample for Tickets #1502

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Add Python code sample for Tickets #1502

merged 4 commits into from
Sep 28, 2022

Conversation

wojake
Copy link
Contributor

@wojake wojake commented Sep 3, 2022

Issue a ticket on an account & use the ticket on a transaction (out of the usual sequence order)

Bounty DGE-93 - Milestone 7

@LimpidCrypto
Copy link
Contributor

LGTM :)

@mDuo13 mDuo13 added the bounties Issues or PRs relating to the XRPL Bounties program, including PRs intended to claim a bounty label Sep 7, 2022
fee="10",
sequence=0,
last_ledger_sequence=None,
ticket_sequence=ticket_sequence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when running the script - the error "TypeError: AccountSet.init() got an unexpected keyword argument 'ticket_sequence'" showed up

Copy link
Contributor Author

@wojake wojake Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mDuo13: I had the same error as well BUT I had to modify xrpl-py's code on AccountSet.init() (added ticket_sequence field) and it worked.
So what should we do now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xrpl-py is missing this common field in its latest release. It will be fixed with the next one:
Issue:
XRPLF/xrpl-py#413

PR:
XRPLF/xrpl-py#428

So ticket_sequence is correct, please keep it :)

@wojake wojake requested review from jonathanlei and removed request for LimpidCrypto September 8, 2022 04:21
@wojake
Copy link
Contributor Author

wojake commented Sep 25, 2022

Are there anything that you'd like to see on this PR for it to be approved @jonathanlei ?

@JST5000
Copy link
Contributor

JST5000 commented Sep 27, 2022

Here's the updated link to the bounty this is related to: https://github.com/XRPLBounties/Proposals/blob/main/bounties/0032%20Python%20Code%20Samples.md

@wojake wojake requested review from JST5000 and justinr1234 and removed request for JST5000 September 28, 2022 08:02
@mDuo13 mDuo13 merged commit 8a12a3c into XRPLF:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounties Issues or PRs relating to the XRPL Bounties program, including PRs intended to claim a bounty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants