-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python code sample for Tickets #1502
Conversation
LGTM :) |
fee="10", | ||
sequence=0, | ||
last_ledger_sequence=None, | ||
ticket_sequence=ticket_sequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when running the script - the error "TypeError: AccountSet.init() got an unexpected keyword argument 'ticket_sequence'" showed up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mDuo13: I had the same error as well BUT I had to modify xrpl-py's code on AccountSet.init() (added ticket_sequence field) and it worked.
So what should we do now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xrpl-py is missing this common field in its latest release. It will be fixed with the next one:
Issue:
XRPLF/xrpl-py#413
So ticket_sequence
is correct, please keep it :)
Are there anything that you'd like to see on this PR for it to be approved @jonathanlei ? |
Here's the updated link to the bounty this is related to: https://github.com/XRPLBounties/Proposals/blob/main/bounties/0032%20Python%20Code%20Samples.md |
Issue a ticket on an account & use the ticket on a transaction (out of the usual sequence order)
Bounty DGE-93 - Milestone 7