Update pagination to use params[:_page] per administrate's changes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See thoughtbot/administrate#1725 Relevant excerpt: > Using the param :page for top-level pagination (ie: index pages as opposed to has_many lists in show pages) conflicts with paginating resources whose type happens to be "Page".
|
Administrate 14 also doesn't work on Windows :) (fixed in thoughtbot/administrate#1698). I'll keep an eye out, but shout if they release it? |
SleeplessByte
approved these changes
Oct 3, 2020
|
will do thanks @SleeplessByte ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if gem is still maintained, but here's a quick necessary fix after a new
administrateis released.See thoughtbot/administrate#1725
NOTE: don't release a new version until after administrate 0.15.0 is released, because 0.14.0 doesn't have the mentioned PR yet https://github.com/thoughtbot/administrate/releases/
Relevant excerpt: