-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check now for bootstrax_state instead. Not sure about the 'else' in l…
….362.
- Loading branch information
Showing
1 changed file
with
15 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59dedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoranAngevaare New attempt (thanks for the suggestions)! I'm always a bit confused by 'else' statements, in this case about the one in l.362. What do you think? :)
59dedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mflierm , looks like you can open (your first?) PR to straxen!
The
else
doesn't hurt/add anything here. There is araise ValueError
at the and of theif
so there is no way you will not be in theelse
regime.In other words, these two blocks are identical in any way. The second if preferable since it's clearer (and shorter)