New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctest change is undocumented MSRV bump #21
Comments
Thank you for your issue! However, I'm only interested in supporting the latest version of the compiler. If you'd like to use a version that is compatible with with 1.32.0 you can continue to use 0.5.2. If you have specific compiler version requirements for your project I would recommend committing your Cargo.lock to avoid this issue. |
For further context: I don't directly depend on Choosing to only support the latest compiler version is a perfectly acceptable policy. The problem is that pushing a MSRV-breaking release as a point-release caused all downstream dependencies to start breaking on older Rust versions, as under Rust-flavoured SemVer, point releases are always considered backwards-compatible (and thus cargo always uses the most recent point release). It would be helpful to document your policy in the crate |
This isn't true, while it's typically best practice to not include lockfiles in a library you totally can include your lockfile, and I would recommend you do so if you want to lock your compiler version. Semver unfortunately doesn't cover how to handle tool changes and so it left to the individual to decide their stability policy on upgrading tools. I'm fine with breakage on older compiler versions. This is a crate that I maintain in my spare time, if people want me to support old compiler versions they can pay me to do so. |
#17, which replaced
cfg(test)
withcfg(doctest)
, was merged back in May, and released two weeks ago as 0.5.3. However,cfg(doctest)
was only stabilised in Rust 1.40.0, which means that this was an undocumented MSRV bump. I ran into problems with this because thetempfile
crate has a MSRV of 1.32.0 but depends onremove_dir_all
, and no longer builds with older Rust versions.The ideal solution would be to publish a 0.5.4 that reverts #17 and has the original MSRV, and then re-publish the current version as 0.6.
The text was updated successfully, but these errors were encountered: