Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.5.3 changed MSRV to Rust 1.40 #26

Closed
clintfred opened this issue Sep 28, 2020 · 3 comments
Closed

release 0.5.3 changed MSRV to Rust 1.40 #26

clintfred opened this issue Sep 28, 2020 · 3 comments

Comments

@clintfred
Copy link

Thanks for your work on this library. I ran into an issue that might be of interest to others.

This commit changed the MSRV to Rust 1.40. I found this out because my project that was picking up remove_dir_all as a transitive dependency. 0.5.1 was fine with Rust 1.38, but 0.5.3 is not.

My suggestion would be to document the project's MSRV and do at least minor version bumps when the MSRV is changed.

I will paste my original error in case it helps someone else find this.

   Compiling remove_dir_all v0.5.3
error[E0658]: `cfg(doctest)` is experimental and subject to change
Error:   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/remove_dir_all-0.5.3/src/lib.rs:12:7
   |
12 | #[cfg(doctest)]
   |       ^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/62210
@tesuji
Copy link

tesuji commented Sep 29, 2020

See #21

@rbtcollins
Copy link
Collaborator

rbtcollins commented Sep 29, 2020 via email

@XAMPPRocky
Copy link
Owner

Thank you for your issue! I've gone ahead and added a note to the README that explains the MSRV policy as @rbtcollins mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants