Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rmui ui_component.dart and ui_core.dart usages; use granular imports #281

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sourcegraph-wk
Copy link

rmui has exports for individual components and an "ui_component" export that has all components. If everywhere uses the individual component exports, then the compiler will only have to consider the component code it needs, resulting in faster build times. But, this only works if everywhere is using the individual component exports.

This batch:

  1. removes the ui_components.dart import. (And the deprecated ui_core.dart, opportunistically)
  2. puts in imports of every one of the individual components
  3. Uses dart fix to remove unused imports, unnecessary imports and duplicate_imports, which will get rid of components you don't need.
  • This may cause some side effects in other files if there are imports that are caught by one of the fixers.
  • There are some redundant imports that are not caught by the fixers, so you may need to manually remove them.
  • Namespaced imports will need manual repair

Once CI is green, you can review and merge it.

Since the same symbols will be used, static analysis and CI passing should be sufficient for QA +1.

For more info reach out to Tom Connell on Slack.

Created by Sourcegraph batch change Workiva/rmui_import.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants