Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mockito with mocktail #2466

Merged
merged 5 commits into from May 18, 2024
Merged

Conversation

sourcegraph-wk
Copy link

In order to help with build times and ease null safety migration, we've opted to replace mockito with mocktail. This batch runs the codemod to swap things out, but may require manual intervention.
FEDX will come around and fix things up unless you beat us to it. Once CI is green and the PR is not in draft, you can review and merge it.
For more info, reach out to #support-frontend-dx on Slack.

Created by Sourcegraph batch change Workiva/mocktail.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@alishadalal-wk alishadalal-wk changed the base branch from master to develop May 16, 2024 10:30
@alishadalal-wk alishadalal-wk marked this pull request as ready for review May 17, 2024 08:03
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 tests pass with mocktail instead of mockito (for Dart) @Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 80ea91e into develop May 18, 2024
4 checks passed
@rmconsole5-wk rmconsole5-wk deleted the batch/fedx/mocktail/frugal branch May 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants