New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix create-module and promote-module #660
chore: Fix create-module and promote-module #660
Conversation
@@ -59,8 +59,10 @@ inquirer | |||
const react = targets.includes('React'); | |||
const componentPath = path.join(cwd, unstable ? `modules/_labs/${name}` : `modules/${name}`); | |||
|
|||
console.log(name, unstable, targets, componentPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep this console.log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦓
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Alan B Smith <alanbsmith@users.noreply.github.com>
The API of mkdirp changed with version 1.0 from callbacks to promises, but we didn't update our use-cases. The change of version was in #531. I tested this with a new module