Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(button): Simplify Button components and prep for theming #471

Merged
merged 53 commits into from Mar 10, 2020
Merged

refactor(button): Simplify Button components and prep for theming #471

merged 53 commits into from Mar 10, 2020

Commits on Mar 9, 2020

  1. refactor: Add initial thoughts on button refactor

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    f1b6473 View commit details
    Browse the repository at this point in the history

  2. refactor: Avoid duplicating size types

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    51344cd View commit details
    Browse the repository at this point in the history

  3. refactor(button): Refactor to new structure for styles

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    9647baa View commit details
    Browse the repository at this point in the history

  4. refactor(button): Add missing growth behavior

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    0d00a7d View commit details
    Browse the repository at this point in the history

  5. fix(button): Fix text button variant

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    249be80 View commit details
    Browse the repository at this point in the history

  6. refactor(button): Use labs styled function

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b3aef49 View commit details
    Browse the repository at this point in the history

  7. refactor(button): Add remainder of package files

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    25231a0 View commit details
    Browse the repository at this point in the history

  8. refactor(button): Add stories for new button components

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    9f08cd2 View commit details
    Browse the repository at this point in the history

  9. refactor(button): Initial pass at refactoring IconButton

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    00e3862 View commit details
    Browse the repository at this point in the history

  10. refactor(button): Remove the need for extra span in IconButton

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    336c393 View commit details
    Browse the repository at this point in the history

  11. refactor(button): Fix text button styling and simplify label styles

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    fc176f7 View commit details
    Browse the repository at this point in the history

  12. refactor(button): Move spacing logic from parts to ButtonContainer

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    4a10905 View commit details
    Browse the repository at this point in the history

  13. refactor(button): Remove unnecessary/redundant color specs

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3cb6686 View commit details
    Browse the repository at this point in the history

  14. refactor(button): Fix deprecated button colors

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    de0de1d View commit details
    Browse the repository at this point in the history

  15. refactor(button): Add deprecation message to deprecated button

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a0a2981 View commit details
    Browse the repository at this point in the history

  16. refactor(button): Add callback for icon button onToggleChange

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    59bbf7c View commit details
    Browse the repository at this point in the history

  17. refactor(button): Account for toggled icon button icon fills

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    263ecff View commit details
    Browse the repository at this point in the history

  18. refactor(button): Implement configurable focus ring

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    587ca4a View commit details
    Browse the repository at this point in the history

  19. refactor(button): Add missing growth behavior

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    4e1ca61 View commit details
    Browse the repository at this point in the history

  20. refactor(button): Remove icon button backgrounds that shouldn't be there

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    7acc64f View commit details
    Browse the repository at this point in the history

  21. refactor(button): Remove unnecessary styles

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    52caff7 View commit details
    Browse the repository at this point in the history

  22. refactor(button): Inline default props

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1e0c961 View commit details
    Browse the repository at this point in the history

  23. refactor(button): Standardize color object API in preps for theming

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    0f5ddb3 View commit details
    Browse the repository at this point in the history

  24. Revert "refactor(button): Inline default props" 

    This inline method is not picked up as default props in TS

This reverts commit f66b4b1f97cb84d1d15189f231d47d4962f3555f.
    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    86ac7ef View commit details
    Browse the repository at this point in the history

  25. fix: Resolve build errors

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1e4cbe0 View commit details
    Browse the repository at this point in the history

  26. fix(labs): Add missing dependency

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5f69c0a View commit details
    Browse the repository at this point in the history

  27. fix(labs): Use correct ref props

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3324c66 View commit details
    Browse the repository at this point in the history

  28. fix(labs): Only call IconButton::onToggleChange on update

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    2e3d8ef View commit details
    Browse the repository at this point in the history

  29. test(labs): Add testing-library/react tests for new button

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a3f8c0d View commit details
    Browse the repository at this point in the history

  30. fix(labs): Resolve storybook console errors

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b669e8c View commit details
    Browse the repository at this point in the history

  31. ci(labs): Enable chromatic snapshots for new buttons

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    47d945b View commit details
    Browse the repository at this point in the history

  32. refactor(button): Change base interface back to ButtonHTMLAttributes

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    bd36758 View commit details
    Browse the repository at this point in the history

  33. chore: Disable no-use-before-define for functions

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    fe7e686 View commit details
    Browse the repository at this point in the history

  34. refactor(button): Clean up spacing/size usage in ButtonLabelIcon

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    71362f6 View commit details
    Browse the repository at this point in the history

  35. fix(button): Ensure IconButton onToggleChange doesn't become stale

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e35aef5 View commit details
    Browse the repository at this point in the history

  36. docs(button): Fix typo in TextButton comment

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    22be892 View commit details
    Browse the repository at this point in the history

  37. refactor(button): Change size enums to string literals

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    0ddf937 View commit details
    Browse the repository at this point in the history

  38. refactor(button): Use new default prop style

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a6ebee5 View commit details
    Browse the repository at this point in the history

  39. docs(button): Update readme

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e2965dd View commit details
    Browse the repository at this point in the history

  40. refactor(button): Replace old button module with refactored button

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    08c1987 View commit details
    Browse the repository at this point in the history

  41. refactor(button): Re-add old stories

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5258f92 View commit details
    Browse the repository at this point in the history

  42. fix(button): Fix a few issues with deprecated_Button

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    462b4cc View commit details
    Browse the repository at this point in the history

  43. fix(button): Use correct sizes for delete button story

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e468b22 View commit details
    Browse the repository at this point in the history

  44. refactor(button): Remove data label support from HighlightButton

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    dcf01c0 View commit details
    Browse the repository at this point in the history

  45. refactor(button): Remove unnecessary fn components from visual testing

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ded967a View commit details
    Browse the repository at this point in the history

  46. refactor(button): Convert text button allCaps into a prop

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    98d9eac View commit details
    Browse the repository at this point in the history

  47. refactor(button): Split outline button variants into their own component

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    d6b9daf View commit details
    Browse the repository at this point in the history

  48. refactor(button): Don't show data label or icon at small sizes

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1a6df22 View commit details
    Browse the repository at this point in the history

  49. refactor(button): Use const instead of enum for ButtonSize

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    531955d View commit details
    Browse the repository at this point in the history

  50. test(button): Update story in failing cypress test

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5514dac View commit details
    Browse the repository at this point in the history

  51. fix(button): Fix button label icon alignment

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ce33cff View commit details
    Browse the repository at this point in the history

  52. fix(modal): Update old delete button references in modal stories

    @anicholls
    anicholls committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    74ac320 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. fix(pagination): Fix pagination buttons after button refactor

    @anicholls
    anicholls committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    592ccf2 View commit details
    Browse the repository at this point in the history