Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Examples Updated to Remove Style Props #2726

Merged
merged 10 commits into from May 15, 2024
Merged

chore: Examples Updated to Remove Style Props #2726

merged 10 commits into from May 15, 2024

Conversation

josh-bagwell
Copy link
Contributor

@josh-bagwell josh-bagwell commented May 6, 2024 •
edited

Summary

Fixes: #2725

Removes style props from examples of components that have been updated in v11 to use new style utils.

Release Category

Documentation

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

/modules/preview-react/
/modules/react/

@cypress Cypress
Copy link

cypress bot commented May 7, 2024 •
edited

Passing run #7298 ↗︎

0 970 3 0 Flakiness 0

Details:

Merge e6d249b into a0579b1...
Project: canvas-kit Commit: 88c7aa06f7 ℹ️
Status: Passed Duration: 05:12 💡
Started: May 15, 2024 5:30 PM Ended: May 15, 2024 5:35 PM

Review all test suite changes for PR #2726 ↗︎

@josh-bagwell josh-bagwell marked this pull request as ready for review May 7, 2024 17:49
@josh-bagwell josh-bagwell added documentation Effects documentation 11.x labels May 7, 2024
@josh-bagwell josh-bagwell added the ready for review Code is ready for review label May 8, 2024
@github-actions github-actions bot requested a review from NicholasBoll May 8, 2024 17:44
RayRedGoose
RayRedGoose reviewed May 13, 2024
View reviewed changes
modules/preview-react/radio/stories/examples/Basic.tsx Outdated Show resolved Hide resolved
modules/preview-react/radio/stories/examples/Custom.tsx Outdated Show resolved Hide resolved
modules/preview-react/radio/stories/examples/Inverse.tsx Outdated Show resolved Hide resolved
modules/react/button/stories/button/examples/ExternalHyperlinkInverse.tsx Outdated Show resolved Hide resolved
modules/react/button/stories/button/examples/HyperlinkInverse.tsx Outdated Show resolved Hide resolved
modules/react/icon/stories/examples/AppletIconList.tsx Outdated Show resolved Hide resolved
modules/react/select/stories/examples/FetchingDynamicItems.tsx Outdated Show resolved Hide resolved
modules/react/select/stories/examples/MenuHeight.tsx Outdated Show resolved Hide resolved
modules/react/table/stories/examples/Basic.tsx Outdated Show resolved Hide resolved
modules/react/table/stories/examples/BasicWithHeading.tsx Outdated Show resolved Hide resolved
@josh-bagwell josh-bagwell added automerge and removed ready for review Code is ready for review labels May 15, 2024
@alanbsmith alanbsmith merged commit 8932c60 into Workday:prerelease/major May 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayRedGoose RayRedGoose RayRedGoose left review comments

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

@NicholasBoll NicholasBoll Awaiting requested review from NicholasBoll

Assignees
No one assigned
Labels
11.x automerge documentation Effects documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josh-bagwell @mannycarrera4 @RayRedGoose @alanbsmith