Translate: Add site tour items #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
reviewed
Sep 4, 2023
wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/class-plugin.php
Show resolved
Hide resolved
trymebytes
force-pushed
the
add-site-tour
branch
from
175b517
to
9c8430e
Compare
|
It works, I just wondered if we could also just enqueue one style and one script since the dependency system would automatically load the required ones? |
|
True, I have updated the PR, thank you! |
|
Looks good to merge after GlotPress/GlotPress#1632 |
|
Although, there was this one hiccup with the meta toolbar step in the tour, were you able to reproduce? Would be good to know if it is a bug in this PR or in GlotPress/GlotPress#1632 |
|
Yes, I'm able to reproduce and I'm taking a look |
|
I have confirmed that it's a bug on GlotPress/GlotPress#1632 |
|
@trymebytes can we close this PR? |
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tour items for translate.wordpress.org, which is loaded only if the correct GET parameter is appended to the page url.
This PR adds a site tour to translate.wordpress.org by adding this filter below;
To test this PR;
site-tourbranch and rungit pullto pull latest updates.site_tour=testto the end of your url for example, to view the site tour on the Events Manager project; https://translate.wordpress.org/projects/wp-plugins/events-manager/dev/art-xemoji/default/?filters%5Bstatus%5D=untranslated&site_tour=test