Replace em-based line-height with unitless values #6537
Conversation
|
Hi @Risad212! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| @@ -508,14 +508,14 @@ code { | |||
| .widefat td ol, | |||
| .widefat td ul { | |||
| font-size: 13px; | |||
| line-height: 1.5em; | |||
| line-height: 1.5; | |||
There was a problem hiding this comment.
Does the line-height value will same? Could you share the screenshot before after chances?
|
no I was replace line height value from em to unitless okay I will do it
again and will create pull request with before after changed
…On Fri, May 17, 2024 at 10:55 AM Mukesh Panchal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/wp-admin/css/common.css
<#6537 (comment)>
:
> @@ -508,14 +508,14 @@ code {
.widefat td ol,
.widefat td ul {
font-size: 13px;
- line-height: 1.5em;
+ line-height: 1.5;
Does the line-height value will same? Could you share the screenshot
before after chances?
—
Reply to this email directly, view it on GitHub
<#6537 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT5AZRFKWEL27RUYOG3WJMTZCWET7AVCNFSM6AAAAABHP7HO6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRSGMZTONZRHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
I found some em-based line-height values in the CSS files within the wp-admin directories.
Files updated:
common.css
install.css
edit.css
nav-menus.css
list-tables.css
Trac ticket: https://core.trac.wordpress.org/ticket/59960