Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check-latest from setup-node. #6530

Closed
wants to merge 30 commits into from

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented May 8, 2024

There appears to be a regression in Node.js 20.13.0 for Windows (see nodejs/node#52884).

This is causing the Windows test builds to fail.

check-latest was only ever meant to be a temporary band-aid, and was added when the minimum version of Node.js was bumped. The latest version at that time was used, and some of the GitHub Action runners did not yet have the correct version. This ensured a version that met the new engines requirements was reliably installed.

Trac ticket: https://core.trac.wordpress.org/ticket/61172


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this May 8, 2024
@desrosj desrosj requested a review from johnbillion May 8, 2024 18:34
@desrosj desrosj marked this pull request as ready for review May 8, 2024 18:34
Copy link

github-actions bot commented May 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented May 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj
Copy link
Contributor Author

desrosj commented May 8, 2024

@desrosj desrosj closed this May 8, 2024
@desrosj desrosj deleted the try/fix-windows-tests branch May 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants