36881 improved hot wiring of set found posts #6529
Open
+93
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set_found_posts method has been refactored to simplify the logic for setting found posts. The main change is the removal of an early bail condition when posts are empty, relying instead on checks outlining specific conditions. The method call for setting found posts has also been moved up in the code for better clarity.
…blocks()`. Follow-up to [57546]. Props immeet94. Fixes #60964. git-svn-id: https://develop.svn.wordpress.org/trunk@58026 602fd350-edb4-49c9-b593-d223f7449a82
…ry` DocBlock. Follow-up to [57373]. Props shailu25. Fixes #61046. git-svn-id: https://develop.svn.wordpress.org/trunk@58027 602fd350-edb4-49c9-b593-d223f7449a82
Removes output of base rules for flow and constrained layout types on themes without theme.json. Props evanltd, poena, isabel_brison, andrewserong, oandregal. See #60981. git-svn-id: https://develop.svn.wordpress.org/trunk@58028 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57793]. Props shailu25, estelaris, audrasjb. See #60732. git-svn-id: https://develop.svn.wordpress.org/trunk@58029 602fd350-edb4-49c9-b593-d223f7449a82
Correctly formats spacing in `get_layout_styles` docblock. Props mukesh27, sabernhardt. See #60981. git-svn-id: https://develop.svn.wordpress.org/trunk@58030 602fd350-edb4-49c9-b593-d223f7449a82
There were several instances of typo corrections in block patterns. This removes the last sentence for a simpler resolution. Props sabernhardt. Fixes #61004. git-svn-id: https://develop.svn.wordpress.org/trunk@58031 602fd350-edb4-49c9-b593-d223f7449a82
Props truptikanzariya. Fixes #61051. See #60699. git-svn-id: https://develop.svn.wordpress.org/trunk@58032 602fd350-edb4-49c9-b593-d223f7449a82
…ttr()`. This changesets adds a check for `$size_array` values to prevent a potential division by zero. Follow-up to [57294]. Props jdekhtiar. Fixes #61054. See #59352. git-svn-id: https://develop.svn.wordpress.org/trunk@58033 602fd350-edb4-49c9-b593-d223f7449a82
…late part. This allows inserting of own blocks into header since the release of the Block Hooks API, specifically after the navigation block. Props tomjcafferkey, poena, shailu25. Fixes #60723. git-svn-id: https://develop.svn.wordpress.org/trunk@58034 602fd350-edb4-49c9-b593-d223f7449a82
…lbar. This changesets replaces the "Edit Site" link with "Site Editor" to avoid duplicate link anchors on multisite admin toolbar. The remaining "Edit site" link takes the user to the site editing screen in the network admin area (`network/site-info.php`) while the new "Site Editor" link takes the user to the site editor (`site-editor.php`). Follow-up to [52158]. See GB27135. Props johnbillion, sabernhardt, audrasjb, johnjamesjacoby, pratiklondhe. Fixes #60977. git-svn-id: https://develop.svn.wordpress.org/trunk@58035 602fd350-edb4-49c9-b593-d223f7449a82
See #60699. git-svn-id: https://develop.svn.wordpress.org/trunk@58037 602fd350-edb4-49c9-b593-d223f7449a82
…REST_TestCase`. All assertions in PHPUnit have a `$message` parameter. Setting this parameter allows to distinguish which assertion is failing when a test runs multiple assertions, making debugging of the tests easier. This optional parameter is now added for `WP_Test_REST_TestCase::assertErrorResponse()`. Follow-up to [34928], [51478]. Props mykolashlyakhtun, antonvlasenko, swissspidy, SergeyBiryukov. Fixes #60426. git-svn-id: https://develop.svn.wordpress.org/trunk@58039 602fd350-edb4-49c9-b593-d223f7449a82
Since [60428] the Tag Processor has been misidentifying single-character funky comments. It has been asserting that the full token-length for a funky comment must be at least three characters after the opening (e.g. `</1>`), but it has been starting to look for the closing `>` after those same three characters. This means that it has been skipping the actual close of these funky comments and swallowing up the next syntax until it finds a `>`, often consuming the next tag in the process. This patch fixes the detector and restores finding the following token. Developed in WordPress#6412 Discussed in https://core.trac.wordpress.org/ticket/60170 Follow-up to [60428]. Fixes #60170. Props dmsnell, gziolo, jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58040 602fd350-edb4-49c9-b593-d223f7449a82
Two `@since` PHPDoc fields, and the version argument to one `_deprecated_argument()` incorrectly stated 6.5.1 as the relevant WordPress version where a change was introduced. This changeset fixes them by setting them to 6.5.3 instead. Follow-up to [57919]. See #60754. git-svn-id: https://develop.svn.wordpress.org/trunk@58042 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [41047]. Props costdev. See #60706. git-svn-id: https://develop.svn.wordpress.org/trunk@58044 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [52226], [58032]. Props nareshbheda, mukesh27. Fixes #61076. git-svn-id: https://develop.svn.wordpress.org/trunk@58045 602fd350-edb4-49c9-b593-d223f7449a82
The purpose of `tests/e2e/specs/gutenberg-plugin.test.js` is to ensure that running the Gutenberg plugin (stable version) on a WordPress `trunk` install doesn't produce any fatals. The test was introduced in [54913], i.e. it has been around since WP 6.2. It makes sense to have it present on older branches, as the Gutenberg plugin not only supports `trunk`, but also the current stable version of WordPress (i.e. currently 6.5), and one version below (6.4). However, it is not expected to work on any earlier versions beyond that; in practice, it has produced errors on some of those. This changeset checks the REST API response from the plugin activation request. If it returns an error with error code `plugin_wp_incompatible`, it skips the test. Props jorbin, johnbillion, swissspidy. Fixes #60971. git-svn-id: https://develop.svn.wordpress.org/trunk@58046 602fd350-edb4-49c9-b593-d223f7449a82
Some tests in the HTML API test suite use `setExpectedIncorrectUsage`. The annotation `@expectedIncorrectUsage` can be used to simplify the tests. Developed in WordPress#6449 Discussed in https://core.trac.wordpress.org/ticket/61080 Fixes #61080. Props dmsnell, jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58048 602fd350-edb4-49c9-b593-d223f7449a82
Import upstream fix from libavifinfo, correcting a potential fatal error. Props yguyon. Fixes #60980. git-svn-id: https://develop.svn.wordpress.org/trunk@58049 602fd350-edb4-49c9-b593-d223f7449a82
…REST_TestCase`. All assertions in PHPUnit have a `$message` parameter. Setting this parameter allows to distinguish which assertion is failing when a test runs multiple assertions, making debugging of the tests easier. Follow-up to [34928], [51478], [58039]. See #60426. git-svn-id: https://develop.svn.wordpress.org/trunk@58051 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [38778], [46829]. Props costdev. See #60706. git-svn-id: https://develop.svn.wordpress.org/trunk@58052 602fd350-edb4-49c9-b593-d223f7449a82
The pullquote block needed the base font size adding back in. This also adds in support for appearance settings for weight and style in addition to the original ticket. This fixes a previous commit which changed the default font size of pullquote blocks, quote blocks and blockquotes. Props sabernhardt. Fixes #61034. git-svn-id: https://develop.svn.wordpress.org/trunk@58053 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [38381]. Props costdev. See #60706. git-svn-id: https://develop.svn.wordpress.org/trunk@58054 602fd350-edb4-49c9-b593-d223f7449a82
…art` post types. This adds the `item_updated` label to Template and Template Part post types registration. This prevents from displaying the default `post updated` label. See WordPress/gutenberg#61146 Follow-up to [52062], [51003]. Props ntsekouras, ellatrix. Fixes #61095. git-svn-id: https://develop.svn.wordpress.org/trunk@58055 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [58028]; adds ticket number to the updated test. Props jorbin, isabel_brison. See #60981. git-svn-id: https://develop.svn.wordpress.org/trunk@58059 602fd350-edb4-49c9-b593-d223f7449a82
[56950] reduced the heading size of About screen headings, but that did not edit the size for smaller viewports. This changeset fixes this issue, and also updates the larger fluid font size (960px - 1200px). Follow-up to [56950]. Props dhruvang21, sabernhardt, khokansardar. Fixes #61030. git-svn-id: https://develop.svn.wordpress.org/trunk@58060 602fd350-edb4-49c9-b593-d223f7449a82
This builds on top of the PHP translation file support added in WordPress 6.5, improving the behavior for projects using solely `.l10n.php` translation files and no `.mo.` and `.po` files. Updates `wp_get_installed_translations()`, which is used when updating language packs and when uninstalling plugins/themes (to remove the translations again), to look for PHP translation files and read metadata from them. Additionally, the file lookup is now cached thanks to using `WP_Textdomain_Registry`. Updates `Language_Pack_Upgrader::check_package()` to allow language packs that only contain PHP translation files. While WordPress.org continues to serve `.mo` and `.po` files, third-party services might want to only use the PHP file format. Props swissspidy. Fixes #60554. git-svn-id: https://develop.svn.wordpress.org/trunk@58061 602fd350-edb4-49c9-b593-d223f7449a82
…res. Improve support for using only PHP translation files. This builds on top of the PHP translation file support added in WordPress 6.5, improving the behavior for projects using solely `.l10n.php` translation files and no `.mo.` and `.po` files. Updates `wp_get_installed_translations()`, which is used when updating language packs and when uninstalling plugins/themes (to remove the translations again), to look for PHP translation files and read metadata from them. Additionally, the file lookup is now cached thanks to using `WP_Textdomain_Registry`. Updates `Language_Pack_Upgrader::check_package()` to allow language packs that only contain PHP translation files. While WordPress.org continues to serve `.mo` and `.po` files, third-party services might want to only use the PHP file format. See #60554. git-svn-id: https://develop.svn.wordpress.org/trunk@58062 602fd350-edb4-49c9-b593-d223f7449a82
Originally added in [34903], these empty CSS blocks serve no purpose. Props ravipatel, sabernhardt. Fixes #61085. git-svn-id: https://develop.svn.wordpress.org/trunk@58063 602fd350-edb4-49c9-b593-d223f7449a82
…ade in [58084]. This file needs to be synced from the Gutenberg repository. See #60699 git-svn-id: https://develop.svn.wordpress.org/trunk@58085 602fd350-edb4-49c9-b593-d223f7449a82
Adds support for passing a `$rules_group` string to wp_style_engine_get_stylesheet_from_css_rules(), so rules can be nested under a media query, layer or other rule. Props isabel_brison, ramonopoly. Fixes #61099. git-svn-id: https://develop.svn.wordpress.org/trunk@58089 602fd350-edb4-49c9-b593-d223f7449a82
…file. Follow-up to [58074], formats docblocks correctly and moves `wp_render_elements_support` to the deprecated file. Props aaronrobertshaw, isabel_brison, mukesh27, spacedmonkey. See #60681. git-svn-id: https://develop.svn.wordpress.org/trunk@58090 602fd350-edb4-49c9-b593-d223f7449a82
Props swissspidy, thelovekesh, peterwilsoncc, bnewboldbsky. Fixes #61020. git-svn-id: https://develop.svn.wordpress.org/trunk@58091 602fd350-edb4-49c9-b593-d223f7449a82
Contributing to WordPress using `wordpress-develop` on GitHub is a useful way collaborate, test, and review suggested changes to the code base. One of the required criteria, though, is including a link to a corresponding Trac ticket. This ensures the PR and associated activity is listed on the Trac ticket, which serves as the source of truth. It’s easy to forget this and newer contributors aren’t always aware of this requirement. This adds a GitHub Actions job that will add a comment as a reminder when no Trac ticket is included. Is the waiting really ended? Two thousand years. Props anamarijapapic, peterwilsoncc. Fixes #60129. git-svn-id: https://develop.svn.wordpress.org/trunk@58092 602fd350-edb4-49c9-b593-d223f7449a82
…-login.php`. This prevents a fatal error if an array is passed instead. Follow-up to [19925], [34909], [58023]. Props dd32, swissspidy. Fixes #61136. git-svn-id: https://develop.svn.wordpress.org/trunk@58093 602fd350-edb4-49c9-b593-d223f7449a82
… space health checks. This allows the disk space values to be changed in the future without requiring a string change. Props afragen, audrasjb, johnbillion Fixes #61115 git-svn-id: https://develop.svn.wordpress.org/trunk@58094 602fd350-edb4-49c9-b593-d223f7449a82
This avoids the need for the locale to be recalculated by code that hooks into this filter. Props swissspidy, mukesh27, johnbillion Fixes #61108 git-svn-id: https://develop.svn.wordpress.org/trunk@58095 602fd350-edb4-49c9-b593-d223f7449a82
This allows the function to be used outside of the loop and brings parity with `get_the_title()`. Follow-up to [1976], [3314], [21735]. Props khokansardar, oglekler. Fixes #61139. git-svn-id: https://develop.svn.wordpress.org/trunk@58096 602fd350-edb4-49c9-b593-d223f7449a82
…ses. This allows a Multisite network to use an address that includes a port name, such as `example.com:1234`, and adds support for this to the local development environment too. You can now run a Multisite installation on the local development environment, for example at `localhost:8889`. This also fixes some bugs with running a single site installation on a port, and updates the testing infrastructure so that the whole test suite runs both with and without a port number. Props djzone, scribu, nacin, ipstenu, F J Kaiser, jeremyfelt, johnjamesjacoby, spacedmonkey, PerS, Clorith, Blackbam, enrico.sorcinelli, Jules Colle, obliviousharmony, desrosj, johnbillion Fixes #21077, #52088 git-svn-id: https://develop.svn.wordpress.org/trunk@58097 602fd350-edb4-49c9-b593-d223f7449a82
…ite from a network. Props johnjamesjacoby, kebbet, cafenoirdesign, Mista-Flo, johnbillion Fixes #51358 git-svn-id: https://develop.svn.wordpress.org/trunk@58098 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [12612]. Props dhruvang21, ankit-k-gupta, audrasjb. Fixes #61098. git-svn-id: https://develop.svn.wordpress.org/trunk@58099 602fd350-edb4-49c9-b593-d223f7449a82
The print styles is meant to append the URL to links. These rules weren't working correctly and this refreshed patch resolves that. Props kjellr, laurelfulford, sabernhardt, poena, shailu25. Fixes #45944. git-svn-id: https://develop.svn.wordpress.org/trunk@58100 602fd350-edb4-49c9-b593-d223f7449a82
This aligns print css to be the same as the scss file. This was suggested by failing tests. Props swisspidy. See #45944 git-svn-id: https://develop.svn.wordpress.org/trunk@58101 602fd350-edb4-49c9-b593-d223f7449a82
Patching print file to get to pass tests after diff file fix. Newline patch. Props swisspidy. See #45944 git-svn-id: https://develop.svn.wordpress.org/trunk@58102 602fd350-edb4-49c9-b593-d223f7449a82
The table font size wasn't reflecting in editor and front. What this does is keep the default and adds in an inherit. Props umesh84, desrosj, shailu25, harshgajipara, darshitrajyaguru97, itpathsolutions. Fixes #56204. git-svn-id: https://develop.svn.wordpress.org/trunk@58103 602fd350-edb4-49c9-b593-d223f7449a82
The pullquote wasn't aligning correctly centrally. This fixes that issue by adding that in. Props umesh84, poena, nithins53, adeltahri, bgoewert, sabernhardt. Fixes #57472. git-svn-id: https://develop.svn.wordpress.org/trunk@58104 602fd350-edb4-49c9-b593-d223f7449a82
This updates the values used for the `$autoload` parameter in various functions to replace 'yes' and 'no' with 'on' and 'off', respectively. Follow-up to [57920]. Props pbearne, mukesh27, joemcgill. Fixes #61045. See #42441. git-svn-id: https://develop.svn.wordpress.org/trunk@58105 602fd350-edb4-49c9-b593-d223f7449a82
The FAQ pattern uses multiple details blocks in a row. This ends up with it behaving as an accordion and opens to issues. In ticket discussion this was decided to be removed to set a good example of how to build. Props poena, alh0319, abditsori, richtabor, joedolson, huzaifaalmesbah, krupajnanda, luminuu, shailu25, swisspidy. Fixes #60335. git-svn-id: https://develop.svn.wordpress.org/trunk@58106 602fd350-edb4-49c9-b593-d223f7449a82
Translation files in this directory are automatically generated and are not subject to any linting considerations. See #59647 git-svn-id: https://develop.svn.wordpress.org/trunk@58107 602fd350-edb4-49c9-b593-d223f7449a82
…tests. This ensures that as much information as possible is shown when an HTTP request fails during an external HTTP test. Fixes #61148 git-svn-id: https://develop.svn.wordpress.org/trunk@58108 602fd350-edb4-49c9-b593-d223f7449a82
…rescheduling a cron event. Props johnbillion, peterwilsoncc See #57271 git-svn-id: https://develop.svn.wordpress.org/trunk@58109 602fd350-edb4-49c9-b593-d223f7449a82
This updates the docblock attributes for `wp_get_attachment_image()` to account for attribute values that are being determined by `wp_get_loading_optimization_attributes()`. Updates docs for `$attr['loading']` and adds docs for `$attr['fetchpriority']`. Props joemcgill, dmsnell. Fixes #59550. git-svn-id: https://develop.svn.wordpress.org/trunk@58110 602fd350-edb4-49c9-b593-d223f7449a82
This adds descriptions to multiple bundled themes. All patterns without the "Inserter" parameter set to "false" or "no", should use the description parameter (These patterns are hidden in the block inserter and do not use the descriptions). Props poena, StringPiggy, oglekler, audrasjb, huzaifaalmesbah, swisspidy. Fixes #59688. git-svn-id: https://develop.svn.wordpress.org/trunk@58111 602fd350-edb4-49c9-b593-d223f7449a82
…lock_supports()`. This prevents a fatal error in `wp_apply_custom_classname_support()`, which expects an array data type for block attributes, and makes sure the block editor can still load if there is a mistake in the attributes of a block. Follow-up to [54498]. Props caercam. Fixes #61151. git-svn-id: https://develop.svn.wordpress.org/trunk@58112 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [54043], [55412], [57793]. Props comecaramelos. Fixes #61159. git-svn-id: https://develop.svn.wordpress.org/trunk@58113 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds a `wp-admin/user/contribute.php` file to allow the "Get Involved" link to work on User Admin. This changeset prevents an unintended 404 that occurs when a logged-in user clicks the "Get Involved" link (located in the menu-bar) from inside of the multisite-specific User Dashboard. Related: r56220, r56309, #23348. Props ignatiusjeroe, audrasjb, tobiasbg. Fixes #61122. git-svn-id: https://develop.svn.wordpress.org/trunk@58118 602fd350-edb4-49c9-b593-d223f7449a82
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @paul, @SergeyBiryukov602fd350-edb4-49c9-b593-d223f7449a82. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
added 2 commits
May 8, 2024 13:25
…into 36881-Improved-hot-wiring-of-set_found_posts
Refactored the formatting and syntax in the WP_Query class to improve the readability of the code. Removed commented code in setFoundPosts test file and adjusted several test cases for better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/36881