Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 6.4 branch to Node.js 20.x #5707

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/performance.yml
Expand Up @@ -71,11 +71,13 @@ jobs:
# - Run performance tests (current commit).
# - Print performance tests results.
# - Check out target commit (target branch or previous commit).
# - Switch Node.js versions if necessary.
# - Install npm dependencies.
# - Build WordPress.
# - Run performance tests (previous/target commit).
# - Print target performance tests results.
# - Reset to original commit.
# - Switch Node.js versions if necessary.
# - Install npm dependencies.
# - Set the environment to the baseline version.
# - Run baseline performance tests.
Expand Down Expand Up @@ -182,6 +184,12 @@ jobs:
fi
git reset --hard $TARGET_SHA

- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
cache: npm

- name: Install npm dependencies
run: npm ci

Expand All @@ -201,6 +209,12 @@ jobs:
- name: Reset to original commit
run: git reset --hard $GITHUB_SHA

- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
cache: npm

- name: Install npm dependencies
run: npm ci

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-npm.yml
Expand Up @@ -76,6 +76,7 @@ jobs:
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
check-latest: true
cache: npm

- name: Log debug information
Expand Down Expand Up @@ -144,6 +145,7 @@ jobs:
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
check-latest: true
cache: npm

- name: Log debug information
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
16
20
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Expand Up @@ -7,8 +7,8 @@
"url": "https://develop.svn.wordpress.org/trunk"
},
"engines": {
"node": ">=16.19.1",
"npm": ">=8.19.3 <9"
"node": ">=20.10.0",
"npm": ">=10.2.3"
},
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down Expand Up @@ -198,4 +198,4 @@
"sync-gutenberg-packages": "grunt sync-gutenberg-packages",
"postsync-gutenberg-packages": "grunt wp-packages:sync-stable-blocks && grunt build --dev && grunt build"
}
}
}