Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @wordpress packages #2220

Closed
wants to merge 1 commit into from

Conversation

noisysocks
Copy link
Member

Update packages to include these bug fixes from Gutenberg:

Trac ticket: https://core.trac.wordpress.org/ticket/54487


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

When testing I noticed there's still a bug related to WordPress/gutenberg#38093. If the browser viewport is small / medium sized (phone or tablet), the Edit Styles link doesn't work as expected. It looks like the sidebar does open, but is closed straight away by some responsive cleverness, and the Styles Welcome Guide only flickers briefly on screen. I'll make a Gutenberg issue for this.

This PR is technically still good though, just a call needs to be made by release leads on the above about whether to backport an additional fix.

@noisysocks
Copy link
Member Author

Thank you @talldan! Create an issue and I'll note it as "good to fix in RC 4 if we can, but not a blocker" along with WordPress/gutenberg#34729.

@talldan
Copy link

talldan commented Jan 24, 2022

Here's an issue: WordPress/gutenberg#38172

@noisysocks
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants