Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @wordpress packages #2184

Closed
wants to merge 2 commits into from

Conversation

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part this is working well, but the issue behind WordPress/gutenberg#38019 doesn't seem to be fixed in testing this branch.

@noisysocks
Copy link
Member Author

Thanks for testing! If I follow the steps in WordPress/gutenberg#37708 I can't repro the issue. I also don't see overflow: hidden on my .edit-site-visual-editor when I look in DevTools which indicates to me that WordPress/gutenberg#38019 is in there. Are you sure you ran grunt build before testing?

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-running the build seems to have fixed the issue ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants