Add notice about visibility in feeds to post edit screen when site is in Coming Soon mode #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being visible on RSS and WordPress.org profile feeds
ryelle
requested changes
Aug 20, 2020
public_html/wp-content/plugins/wordcamp-coming-soon-page/classes/wordcamp-coming-soon-page.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/plugins/wordcamp-coming-soon-page/classes/wordcamp-coming-soon-page.php
Show resolved
Hide resolved
|
Took a fresh look and seems to be working as expected. Ready for the review! |
|
Closes #600 when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the existing notice shown when editing posts when Coming Soon mode is enabled to warn about posts being visible on RSS and WordPress.org profile feeds. Also adds the same notice to Gutenberg block editor.
Fixes #540
Props nao, @ePascalC, @CdrMarks
Screenshots
New notice on classic editor
New notice on the block editor
How to test the changes in this Pull Request: