Notify Community Team when new post is pending in Central #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkevan
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thinking about this - I think it would be better to have this as an mu-plugin, restricting it's use on central via a site id check (or similar), rather than it being ambiguous as a plugin and potentially activated on other WordCamp (or Event) sites.
I'll leave some other feedback inline on the PR.
pkevan
reviewed
Feb 9, 2024
| * @param WP_Post $post Post object. | ||
| */ | ||
| function send_notification_email( $new_status, $old_status, $post ) { | ||
| if ( 'pending' === $new_status && user_can( $post->post_author, 'edit_posts' ) ) { |
There was a problem hiding this comment.
not sure of the purpose of the edit_posts check here - would that not be covered by edit privileges anyway?
pkevan
reviewed
Feb 9, 2024
| wp_mail( 'support@wordcamp.org', $subject, $message ); | ||
|
|
||
| // Save a pointer that notification has been sent. | ||
| update_post_meta( $post->ID, '_ncpp_sent', wp_date( 'Y-m-d H:i:s' ) ); |
There was a problem hiding this comment.
I think we need a method for clearing this on successful save, in case we switch between statuses such as:
draft => pending
pending => draft
draft => pending
pending => publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many WordCamp organisers do have a contributor role on the WordCamp Central website. That means they can write a post, but not publish it. When they are to publish that post, it goes to pending review status.
The team has witnessed a few times that the author doesn't know/understand that no one in Central is looking at pending posts automatically. That results in posts not being published (non at the moment) or delayed.
To avoid these situations, send notification to Community Team when the post status is changed to pending.
Fixes #718
Props @pkevan
Screenshots
How to test the changes in this Pull Request:
After merge & deploy